-
Notifications
You must be signed in to change notification settings - Fork 361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
burn extrinsic integration #1244
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
but what about astar & shiden weights?
@Dinonard just a suggestion to add the dummy keep_alive bool in extrinsic signature to make sure it's not a breaking change when we switch to upstream version |
Local and Shibuya use custom pallet-balances weights since we have integrated account unification into them. |
Sure, why not! |
Minimum allowed line rate is |
Pull Request Summary
Integrates
burn
extrinsic into all runtimes, using a custom fork ofpallet-balances
(link).