Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

burn extrinsic integration #1244

Merged
merged 3 commits into from
May 16, 2024
Merged

burn extrinsic integration #1244

merged 3 commits into from
May 16, 2024

Conversation

Dinonard
Copy link
Member

Pull Request Summary

Integrates burn extrinsic into all runtimes, using a custom fork of pallet-balances (link).

@Dinonard Dinonard added shiden related to shiden runtime astar Related to Astar shibuya related to shibuya runtime This PR/Issue is related to the topic “runtime”. labels May 16, 2024
PierreOssun
PierreOssun previously approved these changes May 16, 2024
Copy link
Member

@PierreOssun PierreOssun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ashutoshvarma
ashutoshvarma previously approved these changes May 16, 2024
Copy link
Member

@ashutoshvarma ashutoshvarma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
but what about astar & shiden weights?

@ashutoshvarma
Copy link
Member

@Dinonard just a suggestion to add the dummy keep_alive bool in extrinsic signature to make sure it's not a breaking change when we switch to upstream version

@Dinonard
Copy link
Member Author

LGTM! but what about astar & shiden weights?

Local and Shibuya use custom pallet-balances weights since we have integrated account unification into them.
For Astar & Shibuya it's not the case, so we can just reuse plain weights from the pallet crate itself.

@Dinonard
Copy link
Member Author

@Dinonard just a suggestion to add the dummy keep_alive bool in extrinsic signature to make sure it's not a breaking change when we switch to upstream version

Sure, why not!

@Dinonard Dinonard dismissed stale reviews from ashutoshvarma and PierreOssun via d02492c May 16, 2024 07:28
Copy link

Code Coverage

Package Line Rate Branch Rate Health
pallets/astar-xcm-benchmarks/src/generic 100% 0%
primitives/src/xcm 64% 0%
precompiles/unified-accounts/src 100% 0%
chain-extensions/types/unified-accounts/src 0% 0%
pallets/dapp-staking-v3/rpc/runtime-api/src 0% 0%
pallets/static-price-provider/src 52% 0%
pallets/unified-accounts/src 86% 0%
chain-extensions/unified-accounts/src 0% 0%
pallets/dynamic-evm-base-fee/src 92% 0%
precompiles/assets-erc20/src 81% 0%
pallets/xvm/src 54% 0%
pallets/oracle-benchmarks/src 0% 0%
precompiles/substrate-ecdsa/src 74% 0%
primitives/src 61% 0%
precompiles/xcm/src 73% 0%
chain-extensions/types/xvm/src 0% 0%
pallets/dapp-staking-v3/src 92% 0%
pallets/inflation/src 83% 0%
precompiles/dapp-staking-v3/src/test 0% 0%
chain-extensions/types/assets/src 0% 0%
pallets/astar-xcm-benchmarks/src 88% 0%
precompiles/xvm/src 75% 0%
pallets/xc-asset-config/src 64% 0%
pallets/ethereum-checked/src 79% 0%
pallets/astar-xcm-benchmarks/src/fungible 100% 0%
precompiles/dispatch-lockdrop/src 86% 0%
pallets/dapp-staking-v3/src/test 0% 0%
precompiles/sr25519/src 64% 0%
pallets/collator-selection/src 92% 0%
chain-extensions/pallet-assets/src 56% 0%
pallets/dapp-staking-v3/src/benchmarking 99% 0%
chain-extensions/xvm/src 0% 0%
precompiles/dapp-staking-v3/src 90% 0%
pallets/dapp-staking-migration/src 0% 0%
pallets/price-aggregator/src 72% 0%
Summary 78% (3599 / 4632) 0% (0 / 0)

Minimum allowed line rate is 50%

@Dinonard Dinonard merged commit e8a29e7 into master May 16, 2024
8 checks passed
@Dinonard Dinonard deleted the feat/burn-extrinsic-integration branch May 16, 2024 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astar Related to Astar runtime This PR/Issue is related to the topic “runtime”. shibuya related to shibuya shiden related to shiden runtime
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants