Fix staked amount too high after unstake issue #1270
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Description
Fixes the issue where the
unstake
call wouldn't correctly update future era staked amount.E.g. for a situation where we have:
staked: { era: 10, amount: 20 }, future_staked: { era: 11, amount: 21 }
unstake(era: 10, amount: 5)
staked: {era: 10, amount: 15}, future_staked: {era: 11, amount: 21}
ContractStake
remaining too high for a contractConsequence
dApps might have ended up in higher tier than they were supposed to.
No actions will be taken around this - whatever dApps earned, it's theirs.
Fix
When
unstake
operation is performed onSingularStakingInfo
struct, it will now correctly account for the scenario where potential future era amount also needs to be reduced.