Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added txpool rpc support #855

Merged
merged 3 commits into from
Feb 13, 2023
Merged

Added txpool rpc support #855

merged 3 commits into from
Feb 13, 2023

Conversation

akru
Copy link
Member

@akru akru commented Feb 3, 2023

Pull Request Summary

Added transaction pool RPC methods:

  • txpool_content
  • txpool_inspect
  • txpool_status

RPC methods enabled if --ethapi=txpool flag added.

Related astar-frame PR: AstarNetwork/astar-frame#128

Check list

  • added or updated unit tests
  • updated Astar official documentation
  • added OnRuntimeUpgrade hook for precompile revert code registration
  • updated spec version
  • updated semver

@andabak andabak requested a review from gluneau February 7, 2023 08:13
Copy link
Member

@Dinonard Dinonard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't have comments, looks good.
Maybe someone who spent more time on the previous review can give more feedback.

I can approve once deps in the .toml file are updated.

Copy link
Contributor

@0x7CFE 0x7CFE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@akru
Copy link
Member Author

akru commented Feb 9, 2023

@Dinonard updated

@akru akru merged commit 7bd370b into 5.x.x Feb 13, 2023
@akru akru deleted the feature/txpool-rpc branch February 13, 2023 09:59
akru added a commit that referenced this pull request Mar 13, 2023
* EVM tracing support (#802)

* Added EVM tracing into local runtime

* Added tracing CLI

* Compilation fixes

* Added EVM tracing host functions

* Added EVM tracing into parachain runtimes

* TracingConfig -> EvmTracingConfig

* Compilation fixes

* Fix clippy errors

* Fix formatting

* Updated dependencies in Cargo.lock

* Updated Cargo.lock

* Update bin/collator/src/local/service.rs

Co-authored-by: Shunsuke Watanabe <shunsukesan.tech@gmail.com>

* Update bin/collator/src/parachain/service.rs

Co-authored-by: Shunsuke Watanabe <shunsukesan.tech@gmail.com>

* Bump astar/shiden runtime specs

Co-authored-by: Shunsuke Watanabe <shunsukesan.tech@gmail.com>

* Fix srtool build

* [CI] temporary disable aarch64 target

* [CI] fix binaries upload for release pipeline

* Fix CI errors

* Update rust toolchain version to 2023-01-11

* Update Cargo.lock

* Added txpool rpc support (#855)

* Added txpool rpc support

* Fix licensing

* Bump dependencies & runtime versions

* Remove outdated migrations from runtimes

* Sort review comments

---------

Co-authored-by: Shunsuke Watanabe <shunsukesan.tech@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants