Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kaizen dApp Staking #1001

Merged
merged 39 commits into from
Nov 10, 2023
Merged

Kaizen dApp Staking #1001

merged 39 commits into from
Nov 10, 2023

Conversation

ayumitk
Copy link
Contributor

@ayumitk ayumitk commented Oct 27, 2023

Pull Request Summary

  • Fetch campaign data and show latest 5 dApps on the portal
  • Add a modal to insert dApps short description
  • Update styling

Check list

  • contains breaking changes
  • adds new feature
  • modifies existing feature (bug fix or improvements)
  • relies on other tasks
  • documentation changes
  • tested on mobile devices
Screenshot 2023-11-01 at 7 16 10 PM Screenshot 2023-11-10 at 8 41 47 AM

@ayumitk ayumitk self-assigned this Oct 27, 2023
@github-actions
Copy link

github-actions bot commented Oct 27, 2023

Visit the preview URL for this PR (updated for commit 4c651d0):

https://astar-apps--pr1001-feat-kaizen-dapp-sta-hykndz2u.web.app

(expires Fri, 17 Nov 2023 10:46:44 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: dd76fe72958fe2910fef9d53f0b4539b82b849db

@ayumitk ayumitk marked this pull request as ready for review November 1, 2023 10:50
@Kahonnohak
Copy link
Contributor

Looks great!!

  • I tried to position: fixed; but again some oder changes and could not quite work it out, please first change this to review properly?
  • Could we remove the arrow on the left when it is starting position and cannot go to the left please? and show this after it went to the right?
  • Could we have transparent gradients that the card disappears by the maximum content width please?

Screenshot 2023-11-01 at 23 00 48
  • I will work on some general contents for this new section
  • This section has been a pain - could you change the section to fit in the width and tidy up the style? and thanks for making this area as same card style, this area also be updatable with Json file? I'll find new image for those area.

Screenshot 2023-11-01 at 22 52 55

@ayumitk
Copy link
Contributor Author

ayumitk commented Nov 3, 2023

@Kahonnohak I've fixed what you pointed out above. Could you review the PR again?

@Kahonnohak
Copy link
Contributor

Thank you!

Few things, sorry it was all in Figma but cannot see them unless preview it.

  • background - lets discuss when your voice is back!!
  • please remove the hover from those two areas (they are not buttons)
Screenshot 2023-11-03 at 13 00 14 Screenshot 2023-11-03 at 13 00 04
  • I see shadow masked
Screenshot 2023-11-03 at 13 28 04 Screenshot 2023-11-03 at 14 32 36
  • Could you apply boxshadow0 0 16px 2px #00000014 for those two above please
  • Please also change the white to FFFFFF80 for the background, and remove boxshadow and hover from the content boxes.
Screenshot 2023-11-03 at 14 38 54
  • Please also change this area
Screenshot 2023-11-03 at 14 40 22

@ayumitk
Copy link
Contributor Author

ayumitk commented Nov 4, 2023

@Kahonnohak I've fixed what you pointed out above and set background-repeat: round; for the background. Could you review the PR again?

Copy link
Contributor

@Kahonnohak Kahonnohak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!!

@ayumitk ayumitk merged commit 64d897a into main Nov 10, 2023
6 checks passed
@ayumitk ayumitk deleted the feat/kaizen-dapp-staking branch November 10, 2023 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants