-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: toast for You do not have enough tokens to pay the transaction fee
#1116
Conversation
Visit the preview URL for this PR (updated for commit fa0b636): https://astar-apps--pr1116-fix-toasts-cwl2oc65.web.app (expires Fri, 19 Jan 2024 14:20:48 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: dd76fe72958fe2910fef9d53f0b4539b82b849db |
You do not have enough tokens to pay the transaction fee
Greg, please fill in the PR summary and checklist |
Thank you! Hmmm, local transfer I still have https://gyazo.com/cc5416a2a4feb2f79e11a34f16a8d515 claim, I did get the toast but I had more than 0.05. or maybe this is already calculated how many eras I need to claim and how much I would need? Can we have the same messages of lacking the balance to pay the fee? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So we are checking if user balance is greater than 0.05. I believe the main reason is because we want user to have some tokens in the future to be able to pay transaction fees.
What we are not checking here is how much tokens will remain in the user wallet after transaction (e.g. balance transfer).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Pull Request Summary
Check list