Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: updates WC version #1278

Merged
merged 5 commits into from
May 31, 2024
Merged

feat: updates WC version #1278

merged 5 commits into from
May 31, 2024

Conversation

impelcrypto
Copy link
Member

@impelcrypto impelcrypto commented May 4, 2024 •
edited
Loading

Pull Request Summary

  • feat: updated WC version
  • feat: modified WC ID (using the same organization as Yoki's)
  • feat: allow using laptop wallet options for staging URL (https://staging.portal.astar.network/)
    • WC won't work at staging URL created by firebase

Check list

  • contains breaking changes
  • adds new feature
  • modifies existing feature (bug fix or improvements)
  • relies on other tasks
  • documentation changes
  • tested on mobile devices

@github-actions GitHub Actions
Copy link

github-actions bot commented May 4, 2024 •
edited
Loading

Visit the preview URL for this PR (updated for commit 009e883):

https://astar-apps--pr1278-test-joyid-izjf5u4c.web.app

(expires Mon, 03 Jun 2024 12:40:10 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: dd76fe72958fe2910fef9d53f0b4539b82b849db

@impelcrypto impelcrypto requested a review from bobo-k2 May 7, 2024 16:05
@impelcrypto impelcrypto assigned gtg7784 and unassigned gtg7784 May 7, 2024
@impelcrypto impelcrypto removed the request for review from bobo-k2 May 7, 2024 16:05
@impelcrypto impelcrypto marked this pull request as ready for review May 27, 2024 09:57
gtg7784
gtg7784 reviewed May 27, 2024
View reviewed changes
src/hooks/helper/wallet.ts Outdated
explorerRecommendedWalletIds: 'ALL',
};

new WalletConnectModal(walletConnectParams as WalletConnectModalConfig);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how about this?

new WalletConnectModal({ projectId, explorerRecommendedWalletIds: isProductionPage ? 'NONE' : 'ALL' } as WalletConnectModalConfig)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, fixed in this commit.

@impelcrypto impelcrypto requested a review from gtg7784 May 27, 2024 14:20
gtg7784
gtg7784 reviewed May 27, 2024
View reviewed changes
Copy link
Member

@gtg7784 gtg7784 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks :)

@gtg7784 gtg7784 self-requested a review May 27, 2024 15:50
@impelcrypto
Copy link
Member Author

@bobo-k2 Please take a look at this PR when you are available

@impelcrypto impelcrypto merged commit a443742 into main May 31, 2024
8 of 9 checks passed
@impelcrypto impelcrypto deleted the test/joyid branch May 31, 2024 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bobo-k2 bobo-k2 bobo-k2 approved these changes

@gtg7784 gtg7784 gtg7784 approved these changes

@codespool codespool Awaiting requested review from codespool

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@impelcrypto @bobo-k2 @gtg7784