-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Centralized configuration - part 1 #1362
Conversation
Visit the preview URL for this PR (updated for commit 11a5204): https://astar-apps--pr1362-feat-central-config-g09g365e.web.app (expires Wed, 07 Aug 2024 08:39:12 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: dd76fe72958fe2910fef9d53f0b4539b82b849db |
src/features.ts
Outdated
export const layerSwapBridgeEnabled = true; | ||
export const celerBridgeEnabled = true; | ||
export const omniBridgeEnabled = true; | ||
export const stargateBridgeEnabled = true; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, variables can be private since they are used only by isBridgeEnabled
function
Fixed in 060d281
@bobo-k2 |
You are right, I updated the variable to return to false, but forgot to remove it. Fixed in 7a974f8 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
Pull Request Summary
This is the first PR to centralize the portal configuration and simply enable/disable certain features, like bridges or XCM
Configuration is stored in
fetures.ts
and settings looks likeThe portal code is updated to take those settings into consideration.
I found that disabling
router-link
, so I created replacement component inCustomRouterLink.vue
Check list