Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: supports French, Portuguese, Korean and Italian #694

Merged
merged 1 commit into from
Feb 20, 2023
Merged

feat: supports French, Portuguese, Korean and Italian #694

merged 1 commit into from
Feb 20, 2023

Conversation

impelcrypto
Copy link
Member

@impelcrypto impelcrypto commented Feb 17, 2023 •
edited
Loading

Pull Request Summary

  • feat: supports French, Portuguese, Korean and Italian
  • feat: remembers selected language (saves the selected language into browser's local storage )

Check list

  • contains breaking changes
  • adds new feature
  • modifies existing feature (bug fix or improvements)
  • relies on other tasks
  • documentation changes
  • tested on mobile devices

Release notes:

  • feat: supports French, Portuguese, Korean and Italian
  • feat: remembers selected language

This pull request makes the following changes:

Adds
image

@github-actions
Copy link

Visit the preview URL for this PR (updated for commit 61fe59f):

https://astar-apps--pr694-feat-multi-languages-lbcoi2xp.web.app

(expires Fri, 24 Feb 2023 04:47:58 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: dd76fe72958fe2910fef9d53f0b4539b82b849db

sirius651
sirius651 approved these changes Feb 17, 2023
View reviewed changes
Copy link
Contributor

@sirius651 sirius651 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Kahonnohak
Kahonnohak approved these changes Feb 19, 2023
View reviewed changes
Copy link
Contributor

@Kahonnohak Kahonnohak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@impelcrypto impelcrypto merged commit a5a5b30 into main Feb 20, 2023
@impelcrypto impelcrypto deleted the feat/multi-languages branch February 20, 2023 04:55
@impelcrypto impelcrypto mentioned this pull request Feb 20, 2023
Closed
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sirius651 sirius651 sirius651 approved these changes

@Kahonnohak Kahonnohak Kahonnohak approved these changes

@bobo-k2 bobo-k2 Awaiting requested review from bobo-k2

@gluneau gluneau Awaiting requested review from gluneau

@niklabh niklabh Awaiting requested review from niklabh

@ashutoshvarma ashutoshvarma Awaiting requested review from ashutoshvarma

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@impelcrypto @sirius651 @Kahonnohak