Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: disabled XCM transfer with Phala and Khala #725

Merged
merged 6 commits into from
Mar 31, 2023
Merged

Conversation

impelcrypto
Copy link
Member

@impelcrypto impelcrypto commented Mar 31, 2023

Pull Request Summary

  • fix: disabled XCM transfer with Phala and Khala
    • temporary disabled it until Phala team create a PR to updating their XCM configuration to XCM V3 CC: @kingsleydon

Check list

  • contains breaking changes
  • adds new feature
  • modifies existing feature (bug fix or improvements)
  • relies on other tasks
  • documentation changes
  • tested on mobile devices

Release notes:

  • fix: disabled XCM transfer with Phala and Khala

This pull request makes the following changes:

Fixes

image

@github-actions
Copy link

github-actions bot commented Mar 31, 2023

Visit the preview URL for this PR (updated for commit aa15249):

https://astar-apps--pr725-fix-disabled-phala-a1464erb.web.app

(expires Fri, 07 Apr 2023 06:37:59 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: dd76fe72958fe2910fef9d53f0b4539b82b849db

@impelcrypto impelcrypto marked this pull request as ready for review March 31, 2023 03:39
Copy link
Contributor

@bobo-k2 bobo-k2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. General comment, I think we should find a way to enable/disable XCM without creating PRs (e.g. some configuration on Firebase or similar)

@impelcrypto
Copy link
Member Author

LGTM. General comment, I think we should find a way to enable/disable XCM without creating PRs (e.g. some configuration on Firebase or similar)

This is a great idea. We should set an value in firebase db.

@impelcrypto impelcrypto merged commit e16c4a5 into main Mar 31, 2023
@impelcrypto impelcrypto deleted the fix/disabled-phala branch March 31, 2023 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants