Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the subtitle from IPFS banner #861

Merged
merged 1 commit into from
Jul 14, 2023
Merged

Remove the subtitle from IPFS banner #861

merged 1 commit into from
Jul 14, 2023

Conversation

ayumitk
Copy link
Contributor

@ayumitk ayumitk commented Jul 13, 2023 •
edited
Loading

Pull Request Summary

Remove the subtitle “portal is now on IPFS” from a banner on Asset page

BEFORE AFTER
Screenshot 2023-07-13 at 9 27 18 AM Screenshot 2023-07-13 at 9 26 52 AM

Check list

  • contains breaking changes
  • adds new feature
  • modifies existing feature (bug fix or improvements)
  • relies on other tasks
  • documentation changes
  • tested on mobile devices

This pull request makes the following changes:

Changes

  • Only changed src/data/dynamic_links.json file

@github-actions
Copy link

Visit the preview URL for this PR (updated for commit 405dafc):

https://astar-apps--pr861-remove-texts-from-ba-suzonxfp.web.app

(expires Thu, 20 Jul 2023 16:37:56 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: dd76fe72958fe2910fef9d53f0b4539b82b849db

@impelcrypto impelcrypto requested a review from gluneau July 13, 2023 17:01
Kahonnohak
Kahonnohak approved these changes Jul 13, 2023
View reviewed changes
Copy link
Contributor

@Kahonnohak Kahonnohak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!!

@impelcrypto impelcrypto merged commit 4cb6bee into main Jul 14, 2023
@impelcrypto impelcrypto deleted the remove-texts-from-banner branch July 14, 2023 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bobo-k2 bobo-k2 bobo-k2 approved these changes

@Kahonnohak Kahonnohak Kahonnohak approved these changes

@impelcrypto impelcrypto impelcrypto approved these changes

@gluneau gluneau Awaiting requested review from gluneau

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ayumitk @bobo-k2 @Kahonnohak @impelcrypto