Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bridge and assets page styling fixes #990

Merged
merged 3 commits into from
Oct 23, 2023
Merged

Bridge and assets page styling fixes #990

merged 3 commits into from
Oct 23, 2023

Conversation

bobo-k2
Copy link
Contributor

@bobo-k2 bobo-k2 commented Oct 23, 2023

Pull Request Summary

image

Check list

  • contains breaking changes
  • adds new feature
  • modifies existing feature (bug fix or improvements)
  • relies on other tasks
  • documentation changes
  • tested on mobile devices

@github-actions
Copy link

github-actions bot commented Oct 23, 2023

Visit the preview URL for this PR (updated for commit 8f968ee):

https://astar-apps--pr990-fix-bridge-styling-shbhbbop.web.app

(expires Mon, 30 Oct 2023 12:35:20 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: dd76fe72958fe2910fef9d53f0b4539b82b849db

@Kahonnohak
Copy link
Contributor

sorry @bobo-k2
Dark theme doesn't have anything. Could you also align with the asset page box please

Screenshot 2023-10-23 at 10 45 34

@Kahonnohak
Copy link
Contributor

@bobo-k2 aw sorry miscommunication

I wanted to keep the current grey border as default and want to have the blue border for hover (dark)
and just add a hover blue for the light theme.

Does it make sense?? Let me know if I made you confused!

@bobo-k2
Copy link
Contributor Author

bobo-k2 commented Oct 23, 2023

@bobo-k2 aw sorry miscommunication

I wanted to keep the current grey border as default and want to have the blue border for hover (dark) and just add a hover blue for the light theme.

Does it make sense?? Let me know if I made you confused!

I understood that you want to have shadow around buttons on the bridge page. Let me fix the styling

Copy link
Contributor

@gluneau gluneau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@Kahonnohak Kahonnohak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@bobo-k2 bobo-k2 merged commit 68eefb5 into main Oct 23, 2023
6 checks passed
@bobo-k2 bobo-k2 deleted the fix/bridge-styling branch October 23, 2023 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants