Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated node command doc #228

Merged
merged 2 commits into from
Jan 17, 2023
Merged

updated node command doc #228

merged 2 commits into from
Jan 17, 2023

Conversation

shunsukew
Copy link
Member

No description provided.

@shunsukew shunsukew requested a review from a team January 16, 2023 11:04
@shunsukew shunsukew requested a review from a team as a code owner January 16, 2023 11:04
@github-actions
Copy link

github-actions bot commented Jan 16, 2023

Visit the preview URL for this PR (updated for commit bec3133):

https://astar-docs--pr228-update-node-command-59dqmidl.web.app

(expires Tue, 24 Jan 2023 04:55:30 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: f2f13e9b593d211faae6343d67a88fac3fd7268d

Copy link
Member

@Dinonard Dinonard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Like the change, only one suggestion.

Comment on lines 703 to 705

Node process will be launched with Parachain ID 2006 for Astar, 2007 for Shiden, 1000 for Shibuya when `--parachain-id` flag is not provided explicitly.
Parachain ID info for each network can be found [here](/docs/quickstart/endpoints/#public-endpoints).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd suggest keeping this.

Copy link
Member Author

@shunsukew shunsukew Jan 16, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

--parachain-id flag is no more supported. So, I'll slitely modify like
What do you think?

Node process will be launched with Parachain ID 2006 for Astar, 2007 for Shiden, 1000 for Shibuya.
Parachain ID info for each network can be found [here](/docs/quickstart/endpoints/#public-endpoints).

@bLd75 bLd75 merged commit 7c43d69 into main Jan 17, 2023
@bLd75 bLd75 deleted the update-node-command-doc branch January 17, 2023 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants