Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/add swanky basic contract #269

Merged
merged 7 commits into from
Feb 21, 2023
Merged

Feature/add swanky basic contract #269

merged 7 commits into from
Feb 21, 2023

Conversation

codespool
Copy link
Contributor

  • add swanky reference to basic-contract page
  • add dev container reference to env setup and swanky pages

@codespool codespool requested review from Maar-io, fiexer and a team February 14, 2023 10:08
@codespool codespool requested a review from a team as a code owner February 14, 2023 10:08
@github-actions
Copy link

github-actions bot commented Feb 14, 2023 •
edited
Loading

Visit the preview URL for this PR (updated for commit ef75af9):

https://astar-docs--pr269-feature-add-swanky-b-d29wotj5.web.app

(expires Mon, 27 Feb 2023 18:12:57 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: f2f13e9b593d211faae6343d67a88fac3fd7268d

Maar-io
Maar-io requested changes Feb 14, 2023
View reviewed changes
Copy link
Member

@Maar-io Maar-io left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR should be on top of feature/build-revamp
These files are now moved and some are reworked

@codespool codespool force-pushed the feature/add-swanky-basic-contract branch from e3be96e to 1810def Compare February 15, 2023 16:24
@codespool
Copy link
Contributor Author

rebased and updated

Maar-io
Maar-io reviewed Feb 20, 2023
View reviewed changes
docs/build/wasm/swanky.md Outdated Show resolved Hide resolved
Maar-io
Maar-io reviewed Feb 20, 2023
View reviewed changes
docs/build/wasm/swanky.md Outdated Show resolved Hide resolved
Maar-io
Maar-io reviewed Feb 20, 2023
View reviewed changes
docs/build/wasm/swanky.md Outdated Show resolved Hide resolved
Maar-io
Maar-io requested changes Feb 20, 2023
View reviewed changes
Copy link
Member

@Maar-io Maar-io left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please address all comments

Maar-io
Maar-io approved these changes Feb 20, 2023
View reviewed changes
Copy link
Member

@Maar-io Maar-io left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codespool codespool merged commit 9a31081 into main Feb 21, 2023
@codespool codespool deleted the feature/add-swanky-basic-contract branch February 21, 2023 10:47
gluneau pushed a commit that referenced this pull request Feb 21, 2023
@codespool @Maar-io @gluneau
Feature/add swanky basic contract (#269)
69ebaf0 
* add swanky reference to basic contract

* add dev container reference to env setup

* add dev container section to ink env

* fix broken link

* update note tags

* resolve pr comments

* ink4 related and proof read

---------

Co-authored-by: Mar.io <34627453+Maar-io@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Maar-io Maar-io Maar-io approved these changes

@fiexer fiexer Awaiting requested review from fiexer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@codespool @Maar-io