Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: added Astar-AI #348

Merged
merged 3 commits into from
May 18, 2023
Merged

feat: added Astar-AI #348

merged 3 commits into from
May 18, 2023

Conversation

impelcrypto
Copy link
Member

image

@github-actions
Copy link

github-actions bot commented May 12, 2023 •
edited
Loading

Visit the preview URL for this PR (updated for commit f4ff0af):

https://astar-docs--pr348-feat-docsbot-5hiubr37.web.app

(expires Mon, 22 May 2023 06:51:22 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: f2f13e9b593d211faae6343d67a88fac3fd7268d

@impelcrypto impelcrypto added the enhancement New feature or request label May 15, 2023
@impelcrypto impelcrypto marked this pull request as ready for review May 15, 2023 06:53
@impelcrypto impelcrypto requested a review from a team May 15, 2023 06:53
@impelcrypto impelcrypto requested a review from a team as a code owner May 15, 2023 06:53
@Kahonnohak
Copy link
Contributor

Astari intro looks bit too long but that is a question to @meganskye otherwise looks good to me:)

@meganskye
Copy link
Contributor

Astari intro looks bit too long but that is a question to @meganskye otherwise looks good to me:)

Thank you for reviewing this :) The Astari intro is pulled from the bot itself, so can be modified without future PRs.

@meganskye
Copy link
Contributor

this looks good to me @impelcrypto but should add that i may not be particularly qualified to perform code review.

gluneau
gluneau approved these changes May 18, 2023
View reviewed changes
Copy link
Contributor

@gluneau gluneau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve this PR.

I would also make the suggestion for the future, style formatting be in its own PR, while new features would go in a different one.

@gluneau gluneau merged commit 707121f into main May 18, 2023
@gluneau gluneau deleted the feat/docsBot branch May 18, 2023 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gluneau gluneau gluneau approved these changes

@niklabh niklabh Awaiting requested review from niklabh

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@impelcrypto @Kahonnohak @meganskye @gluneau