Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ERC20 cross-chain adaption #46

Merged
merged 6 commits into from
Aug 8, 2022
Merged

ERC20 cross-chain adaption #46

merged 6 commits into from
Aug 8, 2022

Conversation

Dinonard
Copy link
Member

@Dinonard Dinonard commented Aug 5, 2022

Migrated docs from @Maar-io to astar-docs repo with small adjustments.

@Dinonard Dinonard requested a review from andabak August 5, 2022 15:26
@github-actions
Copy link

github-actions bot commented Aug 5, 2022

Visit the preview URL for this PR (updated for commit c91d0f1):

https://astar-docs--pr46-doc-erc20-xc-compati-bxwrli80.web.app

(expires Mon, 15 Aug 2022 11:18:40 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

You can renounce ownership of the **XC20** by calling `transferOwnership()` extrinsic on pallet-assets. Note that after this, you won't be able to
change `issuer` or `admin` anymore so make sure those are set correctly.

![polkadot-js-ss-2](https://user-images.githubusercontent.com/34627453/182795097-d145073b-cdf0-4c28-916f-66abb5c68abc.png)
Copy link
Member

@andabak andabak Aug 5, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other images in the docs are local in the local img folder so these two pics could be put likewise. Currently images are numbered 1, 2, 3, 4 but personally I find this very obscure, maybe rather have them named erc20-cross-chain-compatible-1.png and erc20-cross-chain-compatible-2.png

I can do this to be honest I do not know hot to add files to your PR? (only KISS way of doing another PR after you merge this one)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You just need to push to the same branch I'm working on, that's it.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did it.

Copy link
Member

@andabak andabak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment about the pics

@Dinonard
Copy link
Member Author

Dinonard commented Aug 8, 2022

Added XC20+ chapter.

Copy link
Member

@andabak andabak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved all together with the local images added.

@Dinonard Dinonard merged commit 78aa0ba into main Aug 8, 2022
@Dinonard Dinonard deleted the doc/erc20-xc-compatible branch August 8, 2022 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants