Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: update in openbrush section in library page #49

Merged
merged 3 commits into from
Aug 9, 2022

Conversation

sugurujames
Copy link
Contributor

Changed from ink! to Solidity.

@github-actions
Copy link

github-actions bot commented Aug 9, 2022

Visit the preview URL for this PR (updated for commit 12f3659):

https://astar-docs--pr49-feat-update-wasm-sc-e6ehiwc1.web.app

(expires Tue, 16 Aug 2022 13:14:52 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

@@ -51,7 +51,7 @@ Defining a Trait definition is sufficient (a contract that implements that Trait

[`parity-common`](https://github.com/paritytech/parity-common) is a collection of crates that you can use in your ink! contracts.

It offers all Ethereum types and is really useful if you want to port solidity code to ink!.
It offers all Ethereum types and is really useful if you want to port solidity code to Solidity.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It does not make sense - "port solidity code to Solidity"? @SUGURUSEO

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah you are right this shouldn't be changed. Fixed now. @andabakus

Fix intended change.
Copy link
Member

@andabak andabak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sugurujames sugurujames merged commit 7e15433 into main Aug 9, 2022
@sugurujames sugurujames deleted the feat/update-wasm-sc-dev-lib-page branch August 9, 2022 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants