Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve DS doc for devs + fix JP doc #619

Merged
merged 1 commit into from
Mar 2, 2024
Merged

Conversation

Gunit2481
Copy link
Contributor

  • Improved DS registration page for devs (added support & step-by-step guide for Polkadot.js, Talisman, Subwallet and extended smart-contracts descriptions)
  • Fixed Jp translation files

- Improved DS registration page for devs (Polkadot.js, Talisman, Subwallet support)
- Fixed Jp translation files
@Gunit2481 Gunit2481 added documentation Improvements or additions to documentation translation labels Mar 1, 2024
@Gunit2481 Gunit2481 requested review from a team as code owners March 1, 2024 22:13
Copy link

github-actions bot commented Mar 1, 2024

Visit the preview URL for this PR (updated for commit 9edaa93):

https://astar-docs--pr619-improve-ds-registrat-2l9mg5rd.web.app

(expires Fri, 08 Mar 2024 22:18:08 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: f2f13e9b593d211faae6343d67a88fac3fd7268d

@tksarah
Copy link
Contributor

tksarah commented Mar 1, 2024

I think the additional Japanese translation part is good.

Is there a need to change the part where there is a gap between the description and the image on "Manage dApp Staking & claim rewards" page? I think it's an unlocking panel, not an unbonding panel.

https://docs.astar.network/docs/use/dapp-staking/for-stakers/manage-dApp-Staking

Copy link
Contributor

@meganskye meganskye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's go to moon ;)

@meganskye meganskye merged commit 2f1c50e into main Mar 2, 2024
5 checks passed
@meganskye meganskye deleted the Improve-DS-registration-doc branch March 2, 2024 15:07
TomaszWaszczyk pushed a commit to TomaszWaszczyk/astar-docs that referenced this pull request Mar 3, 2024
- Improved DS registration page for devs (Polkadot.js, Talisman, Subwallet support)
- Fixed Jp translation files
TomaszWaszczyk pushed a commit to TomaszWaszczyk/astar-docs that referenced this pull request Mar 4, 2024
- Improved DS registration page for devs (Polkadot.js, Talisman, Subwallet support)
- Fixed Jp translation files
meganskye added a commit that referenced this pull request Mar 13, 2024
* add(bootstrap): begin of translation to Polish language

* Update endpoints.md (#609)

Remove pinknode from RPC providers

* Update index.md - note that we are live on Shiden and Astar (#606)

* init functioning version

* test

* updates to the endpoints available (#607)

* add(pl): front page of documentation

* Mainnet basic data (#611)

* mainnet basic data

* Update bridge-to-zkevm.md

generalize to any wallet

* Update bridge-to-zkevm.md

---------

Co-authored-by: Mar.io <mario@stake.co.jp>
Co-authored-by: Ivan <95318860+andabak@users.noreply.github.com>

* update learn landing page and faq (#613)

* Update quickstart.md (#615)

* Add/local cdk node (#614)

* Create setup-local-validium-node.md

* Rename setup-local-node.md to setup-local-rollup-node.md

* Update setup-local-rollup-node.md

* Pics via upload

* Additzion to setup-local-validium-node.md

* Fix brackets

* Fix brackets 2

* Some.

* Additional updates

* Final updates

* Final update rollup

* Update headline

* Post replica1

* Post replica 2

* Doc typos fix & Jp doc update (#617)

* Typo fix & Jp doc update

* Fix errors

* Add Astar ZK RPC node page (#618)

* Add Astar ZK RPC node page

* minor rephrasing

---------

Co-authored-by: Megan Skye Phoenix <58894568+meganskye@users.noreply.github.com>

* Update (#619)

- Improved DS registration page for devs (Polkadot.js, Talisman, Subwallet support)
- Fixed Jp translation files

* add(polish): test of build

* add(pl): Czym jest Astar zkEVM?

* add(formatting): white spaces

* Mainnet basic data (#611)

* mainnet basic data

* Update bridge-to-zkevm.md

generalize to any wallet

* Update bridge-to-zkevm.md

---------

Co-authored-by: Mar.io <mario@stake.co.jp>
Co-authored-by: Ivan <95318860+andabak@users.noreply.github.com>

* Doc typos fix & Jp doc update (#617)

* Typo fix & Jp doc update

* Fix errors

* Update (#619)

- Improved DS registration page for devs (Polkadot.js, Talisman, Subwallet support)
- Fixed Jp translation files

* add(fix): navbar

* fix algolia

---------

Co-authored-by: Josip Š <106158728+josip-simunovic88@users.noreply.github.com>
Co-authored-by: Ivan <95318860+andabak@users.noreply.github.com>
Co-authored-by: Gregory Luneau <greg@astar.network>
Co-authored-by: Mar.io <34627453+Maar-io@users.noreply.github.com>
Co-authored-by: Mar.io <mario@stake.co.jp>
Co-authored-by: Megan Skye <58894568+meganskye@users.noreply.github.com>
Co-authored-by: Marijan <77665447+mc2eqe@users.noreply.github.com>
Co-authored-by: Gaius_sama <85451570+Gunit2481@users.noreply.github.com>
Co-authored-by: bLd759 <18489502+bLd75@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation translation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants