Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: added transfer-tokens page #76

Merged
merged 15 commits into from
Sep 9, 2022
Merged

docs: added transfer-tokens page #76

merged 15 commits into from
Sep 9, 2022

Conversation

impelcrypto
Copy link
Member

@github-actions
Copy link

github-actions bot commented Sep 6, 2022 •
edited
Loading

Visit the preview URL for this PR (updated for commit 562c2f6):

https://astar-docs--pr76-feat-added-new-trans-x5i7u5k2.web.app

(expires Wed, 14 Sep 2022 08:20:35 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

@Kahonnohak
Copy link
Contributor

Would it be possible to add this to this PR? If so please do.

<meta name=“description” content=“Documentation of Astar and Shiden Network - The Future of Smart Contracts for Multichain - both WebAssembly (WASM) and EVM using XCM. Tutorials, user guides and tools for developers and builders.“>

@impelcrypto
Copy link
Member Author

@Kahonnohak updated!

@Kahonnohak
Copy link
Contributor

mmmm I think some layouts are now broken.

@Kahonnohak
Copy link
Contributor

I don't know what is wrong but this link is not working. Please help. Thanks!
Screenshot 2022-09-07 at 11 48 53

@impelcrypto
Copy link
Member Author

@Kahonnohak Fixed.

I don't know what is wrong but this link is not working. Please help. Thanks!

Because there was a space here.

@Kahonnohak
Copy link
Contributor

Thank you😭

Kahonnohak
Kahonnohak approved these changes Sep 7, 2022
View reviewed changes
Copy link
Contributor

@Kahonnohak Kahonnohak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Kahonnohak and others added 5 commits September 7, 2022 13:52
@Kahonnohak
Update transfer-tokens.md
bdf5182 
added a link to set-up-metamask
@Kahonnohak
Update transfer-tokens.md
09258fa 
added some periods
@andabak
Update transfer-tokens.md
564acc1 
more warnings about reading info from exchanges as well
@andabak
Update setup-metamask.md
5fc92cd 
typo Alternatively
@andabak
Update transfer-tokens.md
faa8226 
typo: trickey --> tricky
andabak
andabak requested changes Sep 7, 2022
View reviewed changes
Copy link
Member

@andabak andabak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is one broken link (cannot understand why is not working.)
maybe @impelcrypto will identify why?

the one in https://astar-docs--pr76-feat-added-new-trans-x5i7u5k2.web.app/docs/user-guides/setup-metamask

image

docs/user-guides/setup-metamask.md Outdated Show resolved Hide resolved
docs/user-guides/setup-metamask.md Show resolved Hide resolved
docs/user-guides/setup-metamask.md Outdated Show resolved Hide resolved
docs/user-guides/transfer-tokens.md Show resolved Hide resolved
docs/user-guides/transfer-tokens.md Outdated Show resolved Hide resolved
@Kahonnohak Kahonnohak merged commit c73ce67 into main Sep 9, 2022
@Kahonnohak Kahonnohak deleted the feat/added-new-transfer-page branch September 9, 2022 00:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kahonnohak Kahonnohak Kahonnohak approved these changes

@andabak andabak andabak approved these changes

@fiexer fiexer Awaiting requested review from fiexer

@hoonsubin hoonsubin Awaiting requested review from hoonsubin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@impelcrypto @Kahonnohak @andabak