This repository has been archived by the owner on Oct 30, 2024. It is now read-only.
API bump v0.1.14 #32
Merged
API bump v0.1.14 #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
niklabh
commented
Jan 30, 2023
•
niklabh
commented
- Update polkadot js API
- Removed api-derived stakers function
impelcrypto
approved these changes
Feb 10, 2023
impelcrypto
suggested changes
Feb 10, 2023
|
Please provide PR description. At least put what you did and why. Also some tips for reviewers can be helpful if applicable. |
bobo-k2
suggested changes
Feb 10, 2023
| @@ -17,23 +15,6 @@ export function stakers( | |||
| ): (contractAddress: ContractAddress) => Observable<AccountId[]> { | |||
There was a problem hiding this comment.
Why you removed this function? If not needed than maybe to remove whole function instead having one which does nothing.
There was a problem hiding this comment.
In current main branch this function does not return values. If we remove the whole function any external code using it will throw error. So better to have this stub with depreciation warning rather than removing completely.
Sorry, it was false alarm. Type annotation is working. |
impelcrypto
approved these changes
Feb 10, 2023
bobo-k2
approved these changes
Feb 10, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.