Convert Starship to support CMake #25
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the comversion to CMake the harbour-starship dir is no longer required. Previously it was needed to enable building of both the harbour-starship application, and is dependancies.
Convert the project to CMake from QMake
|
This now looks good to me but the PR it depends on AsteroidOS/asteroidsyncservice#54 should also have a cleaner git log (without the merge commits etc...) |
Sorry for the long tail on this, I'll try to get it all cleaned up this weekend 😄 |
No reason to apologize at all! So great to see you contributing. |
|
losing this for now, as its massively out of date. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apologies, I somehow managed to close my previous PR so I have recreated it here
This PR converts Starship over to the CMake build system, to bring it into alignment with asteroidsyncservice and other AsteroidOS projects.
This PR is dependent on AsteroidOS/asteroidsyncservice#54 first being merged, so that the submodule can then be updated.