Quick fix for FWHM bug #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a quick fix for a bug that can sometimes causes a tabulated data optical filter to fail to calculate its FWHM.
The cause of the problem was that the peak transmission value calculated by maximising the linearly interpolated transmission was slightly lower than the maximum transmission value in the tabulated data. For tabulated data filters the latter was being used to find wavelengths that bracketed the half maximum points, but then the peak value was being recalculated using the former method, which sometimes resulted in the half maximum points being outside the brackets. This quick fix avoids the problem by not recalculating the peak transmission value for tabulated data filters, and simply uses the maximum value from the tabulated data instead.
A better fix would also stop using solvers to find the half maximum points for the tabulated filters too, as a simple linear interpolation would be more robust and efficient in their case.