Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pack): clojure language pack #248

Merged
merged 1 commit into from
Jun 1, 2023
Merged

feat(pack): clojure language pack #248

merged 1 commit into from
Jun 1, 2023

Conversation

practicalli-johnny
Copy link
Contributor

@practicalli-johnny practicalli-johnny commented May 31, 2023

Add a clojure pack to the Astrocommunity

  • Treesitter parser: clojure
  • LSP: clojure_lsp
  • Plugins: "Olical/conjure" and "gpanders/nvim-parinfer"
  • Add autocmd to disable lsp diagnostics in Conjure log
  • Add autocmd to configure comments to Clojure style guide

Additional Config

Add a localleader mapping to the user config (if not defined in AstroNvim) to enable Conjure key mappings, e.g. , e r to evaluate top level root

Define a localleader mapping in options.lua

return {
  g = {
    mapleader = " ",                 -- sets vim.g.mapleader
    maplocalleader = ",",            -- Set local leader key binding
    -- additional options...
  },
}

An autocmd is used to set ;; as the line comment character, to follow the Clojure style guide.

Resolve #247

@practicalli-johnny practicalli-johnny changed the title feat(pack) clojure language pack feat: clojure language pack May 31, 2023
Copy link
Member

@mehalter mehalter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this great contribution! Just a few easy edits for some small things I noticed that should get fixed.

lua/astrocommunity/pack/clojure/clojure.lua Outdated Show resolved Hide resolved
lua/astrocommunity/pack/clojure/clojure.lua Outdated Show resolved Hide resolved
lua/astrocommunity/pack/clojure/clojure.lua Outdated Show resolved Hide resolved
@mehalter mehalter changed the title feat: clojure language pack feat(pack): clojure language pack Jun 1, 2023
Add a clojure pack to the Astrocommunity

- Treesitter parser: clojure
- LSP: clojure_lsp
- Plugins: "Olical/conjure" and "gpanders/nvim-parinfer"
- Add autocmd to disable lsp diagnostics in Conjure log
- Add autocmd to configure comments to Clojure style guide

Conjure defines key mappings relative to the `<localleader>` by default.
Define localleader in `options.lua` using `g = {maplocalleader = ","}`

An autocmd is used to set ;; as the line comment character, to follow the Clojure style guide.

[Resolve: #247]
Copy link
Member

@mehalter mehalter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Thanks so much! Also just to let you know I have added a default localleader to AstroNvim nightly and it will come out with the next release. We are just waiting on a couple small things before we do the release.

@mehalter mehalter merged commit dd38bb9 into AstroNvim:main Jun 1, 2023
@practicalli-johnny practicalli-johnny deleted the feat-pack-clojure branch June 1, 2023 13:58
Uzaaft pushed a commit that referenced this pull request Jun 11, 2023
feat: clojure language pack

Add a clojure pack to the Astrocommunity

- Treesitter parser: clojure
- LSP: clojure_lsp
- Plugins: "Olical/conjure" and "gpanders/nvim-parinfer"
- Add autocmd to disable lsp diagnostics in Conjure log
- Add autocmd to configure comments to Clojure style guide

Conjure defines key mappings relative to the `<localleader>` by default.
Define localleader in `options.lua` using `g = {maplocalleader = ","}`

An autocmd is used to set ;; as the line comment character, to follow the Clojure style guide.

[Resolve: #247]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: add clojure pack
2 participants