Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support usage as HOC for decorating class components #11

Merged
merged 3 commits into from
Sep 30, 2018

Conversation

eliperelman
Copy link
Contributor

Fixes #8.

@eliperelman
Copy link
Contributor Author

I also tested this out in the demo by replacing:

const App = epitath(function*() {
  console.log('Rendering again!');

with:

const App = epitath(class Demo extends React.Component {
  * render() {
    console.log('Rendering again!');

@fakenickels fakenickels requested review from fakenickels and a team September 27, 2018 19:36
@fakenickels
Copy link
Contributor

Thanks @eliperelman, added some comments and after that we're good to merge

@eliperelman
Copy link
Contributor Author

@grsabreu done!

@fakenickels fakenickels merged commit b7362ea into Astrocoders:master Sep 30, 2018
@fakenickels
Copy link
Contributor

Thanks for your contribution @eliperelman , I'll be updating the project contribution soon!

@eliperelman
Copy link
Contributor Author

Sounds great, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants