Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test if Format.yml works in a PR from fork #107

Closed
wants to merge 4 commits into from
Closed

Test if Format.yml works in a PR from fork #107

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d3890cc
add `.JuliaFormatter.toml`
hyrodium Sep 23, 2023
f5601a2
Change style to blue
hyrodium Nov 16, 2023
85e4f7f
add Format.yml
hyrodium Nov 16, 2023
856b3b6
break format rule to check if Format.yml works
hyrodium Dec 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .JuliaFormetter.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
style = "blue"
8 changes: 8 additions & 0 deletions .github/workflows/Format.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
name: Format suggestions
on:
pull_request:
jobs:
code-style:
runs-on: ubuntu-latest
steps:
- uses: julia-actions/julia-format@v2
2 changes: 1 addition & 1 deletion src/obj.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,9 @@
"""
loadobj(shapepath::String; scale=1, message=true) -> nodes, faces
"""
function loadobj(shapepath::String; scale=1, static=true, message=true)

Check warning on line 12 in src/obj.jl

View workflow job for this annotation

GitHub Actions / code-style 

[JuliaFormatter] reported by reviewdog 🐶


Raw Output:
src/obj.jl:12:-function loadobj(shapepath::String; scale=1, static=true, message=true)
src/obj.jl:12:+function loadobj(shapepath::String; scale = 1, static = true, message = true)

nodes = SVector{3, Float64}[]
nodes = SVector{3, Float64}[]

Check warning on line 14 in src/obj.jl

View workflow job for this annotation

GitHub Actions / code-style 

[JuliaFormatter] reported by reviewdog 🐶


Raw Output:
src/obj.jl:14:-    nodes = SVector{3,   Float64}[]
src/obj.jl:15:-    faces = SVector{3, Int64}[]
src/obj.jl:14:+    nodes = SVector{3,Float64}[]
src/obj.jl:15:+    faces = SVector{3,Int64}[]
faces = SVector{3, Int64}[]

open(shapepath, "r") do f
Expand Down
Loading