Drop cookie value unescaping, close #858

Author: slandelle

api/src/main/java/org/asynchttpclient/cookie/Cookie.java

@@ -14,14 +14,13 @@
 
 public class Cookie {
 
-    public static Cookie newValidCookie(String name, String value, String rawValue, String domain, String path, long expires, int maxAge,
-            boolean secure, boolean httpOnly) {
 
         if (name == null) {
             throw new NullPointerException("name");
         }
         name = name.trim();
-        if (name.isEmpty()) {
             throw new IllegalArgumentException("empty name");
         }
 
@@ -42,8 +41,7 @@ public static Cookie newValidCookie(String name, String value, String rawValue,
             case ',':
             case ';':
             case '=':
-                throw new IllegalArgumentException("name contains one of the following prohibited characters: " + "=,; \\t\\r\\n\\v\\f: "
-                        + name);
             }
         }
 
@@ -58,15 +56,15 @@ public static Cookie newValidCookie(String name, String value, String rawValue,
         domain = validateValue("domain", domain);
         path = validateValue("path", path);
 
-        return new Cookie(name, value, rawValue, domain, path, expires, maxAge, secure, httpOnly);
     }
 
     private static String validateValue(String name, String value) {
         if (value == null) {
             return null;
         }
         value = value.trim();
-        if (value.isEmpty()) {
             return null;
         }
 
@@ -78,28 +76,26 @@ private static String validateValue(String name, String value) {
             case '\f':
             case 0x0b:
             case ';':
-                throw new IllegalArgumentException(name + " contains one of the following prohibited characters: " + ";\\r\\n\\f\\v ("
-                        + value + ')');
             }
         }
         return value;
     }
 
     private final String name;
     private final String value;
-    private final String rawValue;
     private final String domain;
     private final String path;
     private long expires;
     private final int maxAge;
     private final boolean secure;
     private final boolean httpOnly;
 
-    public Cookie(String name, String value, String rawValue, String domain, String path, long expires, int maxAge, boolean secure,
-            boolean httpOnly) {
         this.name = name;
         this.value = value;
-        this.rawValue = rawValue;
         this.domain = domain;
         this.path = path;
         this.expires = expires;
@@ -120,8 +116,8 @@ public String getValue() {
         return value;
     }
 
-    public String getRawValue() {
-        return rawValue;
     }
 
     public String getPath() {
@@ -131,7 +127,7 @@ public String getPath() {
     public long getExpires() {
         return expires;
     }
-
     public int getMaxAge() {
         return maxAge;
     }
@@ -149,7 +145,10 @@ public String toString() {
         StringBuilder buf = new StringBuilder();
         buf.append(name);
         buf.append('=');
-        buf.append(rawValue);
+            buf.append('"').append(value).append('"');
+        else
+            buf.append(value);
         if (domain != null) {
             buf.append("; domain=");
             buf.append(domain);