Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update dependencies #921

Merged
merged 5 commits into from
Feb 12, 2021
Merged

chore: update dependencies #921

merged 5 commits into from
Feb 12, 2021

Conversation

mikaelbr
Copy link
Collaborator

@mikaelbr mikaelbr commented Feb 11, 2021

Not bumping Firebase dependencies as this
requires bump for cocopods to 1.10.0 which
is not supported by AppCenter as of now.

Still uses eslint-plugin-react-native@3.8.1 due to Intellicode/eslint-plugin-react-native#270

Not bumping Firebase dependencies as this
requires bump for cocopods to 1.10.0 which
is not supported by AppCenter as of now.
@mikaelbr mikaelbr marked this pull request as draft February 11, 2021 15:22
@mikaelbr mikaelbr marked this pull request as ready for review February 12, 2021 09:45
@mikaelbr
Copy link
Collaborator Author

I think this is something best reviewed by running locally

@cbrevik
Copy link
Contributor

cbrevik commented Feb 12, 2021

I'm having some trouble testing on Android (something up with my dev env), but have you tested the changes on Android?

@mikaelbr
Copy link
Collaborator Author

I did. But I had to clear the cache and do some aggressive cleaning. I hoped it would be better for others or with a clean install.

Copy link
Contributor

@cbrevik cbrevik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worked fine for me on iOS 🙆🏻‍♂️

@gorandalum
Copy link
Member

Worked for me on Android Simulator

@mikaelbr mikaelbr merged commit 971c552 into master Feb 12, 2021
@mikaelbr mikaelbr deleted the mikael/bump-versions branch February 12, 2021 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants