Skip to content

[BN] Update 01.md #717

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

kishordgupta
Copy link
Contributor

minor change

@@ -7,14 +7,15 @@ translator: Taniya Seth
---


## লেকচার ভাগ
## লেকচার বিভাগ
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"A" in English would be better here I think or we can also put "ক" here


## লেকচার ভাগ বী

## লেকচার বিভাগ বী

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here "B" or "খ" would work better here

@Atcold
Copy link
Owner

Atcold commented Dec 13, 2020

@khalidsaifullaah, you've approved the changes, but asked to edit.
I'm confused now. Is this okay for merging or are there pending edits?

Please, let me know what your review is.

Copy link
Contributor

@khalidsaifullaah khalidsaifullaah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kishordgupta if you could edit those sections mentioned in the earlier review then @Atcold can merge these changes, thanks.

@khalidsaifullaah
Copy link
Contributor

@khalidsaifullaah, you've approved the changes, but asked to edit.
I'm confused now. Is this okay for merging or are there pending edits?

Please, let me know what your review is.

Really sorry @Atcold, I wasn't much aware of this "Review" system before, so it was my bad. I guess you could merge the PR after the changes are made.

@Atcold Atcold reopened this Dec 14, 2020
@Atcold
Copy link
Owner

Atcold commented Dec 14, 2020

Don't be sorry @karanchahal.
When you review the PR, you can choose "comment", "accept", or "ask for edit".
Depending which one you pick you'll be sending a different message to me and the PR owner.
Also, make sure people are aware of the translation guidelines. For example, this PR doesn't have a language code in the title (@kishordgupta can still edit that).

@kishordgupta, after you've pushed your edits I'll merge, if @karanchahal gives the green light.

Copy link
Owner

@Atcold Atcold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, here's a "request changes" status.

@karanchahal
Copy link
Contributor

I have no clue what this language is @Atcold ! 🤣

@khalidsaifullaah
Copy link
Contributor

I have no clue what this language is @Atcold ! 🤣

I think @Atcold tagged you instead of tagging me, because of our name's initial letter I guess😄

@Atcold
Copy link
Owner

Atcold commented Dec 15, 2020

Hey guys… y'all have a k- and many letters user… 🤣🤣🤣
The message was supposed to be:

@khalidsaifullaah, don't be sorry.

@kishordgupta, after you've pushed your edits I'll merge, if @khalidsaifullaah gives the green light.

Anyhow, follow the instructions now 😛😛😛

@kishordgupta kishordgupta changed the title Update 01.md [BN] Update 01.md Dec 20, 2020
@kishordgupta
Copy link
Contributor Author

@khalidsaifullaah, other translators are using এ instead of "ক"

@khalidsaifullaah
Copy link
Contributor

@khalidsaifullaah, other translators are using এ instead of "ক"

Yeah, I saw that, So, I guess we're doing it that way, we're good to go then...

Copy link
Contributor

@khalidsaifullaah khalidsaifullaah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Atcold can merge it now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants