-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sort singular values #46
Merged
Merged
Commits on Sep 18, 2016
-
Configuration menu - View commit details
-
Copy full SHA for 61b05ee - Browse repository at this point
Copy the full SHA 61b05eeView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3692ad2 - Browse repository at this point
Copy the full SHA 3692ad2View commit details -
Test ordering of singular values
Interestingly, the singular values just happen to be ordered already for the tall and short and matrices, while they are not ordered correctly for the square example. Before we implement the sorting of the matrices, we at least want these tests to fail, so we must construct new matrix examples for which the singular values hopefully come out unsorted.
Configuration menu - View commit details
-
Copy full SHA for fed5a0a - Browse repository at this point
Copy the full SHA fed5a0aView commit details -
Add tests for sorted singular values
Before implementing the sort functionality, it is useful to have some tests that fail because the singular values are not sorted. However, it appears that the computation of the SVD for these examples does not even (currently) finish!
Configuration menu - View commit details
-
Copy full SHA for 54a7744 - Browse repository at this point
Copy the full SHA 54a7744View commit details
Commits on Sep 19, 2016
-
Thanks to @AtheMathmo for figuring out the issue. See AtheMathmo#46 for a discussion of the problem.
Configuration menu - View commit details
-
Copy full SHA for b94a609 - Browse repository at this point
Copy the full SHA b94a609View commit details
Commits on Sep 20, 2016
-
Configuration menu - View commit details
-
Copy full SHA for 38a7997 - Browse repository at this point
Copy the full SHA 38a7997View commit details
Commits on Sep 21, 2016
-
Configuration menu - View commit details
-
Copy full SHA for dd44d14 - Browse repository at this point
Copy the full SHA dd44d14View commit details -
Configuration menu - View commit details
-
Copy full SHA for a86d113 - Browse repository at this point
Copy the full SHA a86d113View commit details
Commits on Sep 22, 2016
-
Configuration menu - View commit details
-
Copy full SHA for 01013a6 - Browse repository at this point
Copy the full SHA 01013a6View commit details -
Implement temporary Epsilon trait
The idea is to remove this once epsilon() lands in the next version of the num crate.
Configuration menu - View commit details
-
Copy full SHA for 677930e - Browse repository at this point
Copy the full SHA 677930eView commit details -
Since the benchmarks test module-internal methods, the benchmarks can not reside in the benches/ subdirectory. However, since the benchmarks must be run on nightly, it involves some complication. Hence, in order to run these benchmarks, you must add the 'nightly' feature to the compilation, like so: `cargo bench --features nightly`
Configuration menu - View commit details
-
Copy full SHA for d227259 - Browse repository at this point
Copy the full SHA d227259View commit details
Commits on Sep 23, 2016
-
Remove 'nightly' benchmarking of internal modules
Instead just bench the public .svd() method along with the other benchmarks.
Configuration menu - View commit details
-
Copy full SHA for 1e0f7a7 - Browse repository at this point
Copy the full SHA 1e0f7a7View commit details
Commits on Sep 24, 2016
-
Configuration menu - View commit details
-
Copy full SHA for 6a49d87 - Browse repository at this point
Copy the full SHA 6a49d87View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.