Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort singular values #46

Merged
merged 13 commits into from
Sep 24, 2016
Merged

Commits on Sep 18, 2016

  1. Configuration menu
    Copy the full SHA
    61b05ee View commit details
    Browse the repository at this point in the history
  2. Clean up SVD tests

    Andlon committed Sep 18, 2016
    Configuration menu
    Copy the full SHA
    3692ad2 View commit details
    Browse the repository at this point in the history
  3. Test ordering of singular values

    Interestingly, the singular values just happen to be
    ordered already for the tall and short and matrices,
    while they are not ordered correctly
    for the square example. Before we implement the
    sorting of the matrices, we at least want these tests
    to fail, so we must construct new matrix examples
    for which the singular values hopefully come out
    unsorted.
    Andlon committed Sep 18, 2016
    Configuration menu
    Copy the full SHA
    fed5a0a View commit details
    Browse the repository at this point in the history
  4. Add tests for sorted singular values

    Before implementing the sort functionality,
    it is useful to have some tests that fail because
    the singular values are not sorted. However,
    it appears that the computation of the SVD
    for these examples does not even (currently) finish!
    Andlon committed Sep 18, 2016
    Configuration menu
    Copy the full SHA
    54a7744 View commit details
    Browse the repository at this point in the history

Commits on Sep 19, 2016

  1. Fix SVD non-termination issue

    Thanks to @AtheMathmo for figuring out the issue.
    See AtheMathmo#46 for
    a discussion of the problem.
    Andlon committed Sep 19, 2016
    Configuration menu
    Copy the full SHA
    b94a609 View commit details
    Browse the repository at this point in the history

Commits on Sep 20, 2016

  1. Configuration menu
    Copy the full SHA
    38a7997 View commit details
    Browse the repository at this point in the history

Commits on Sep 21, 2016

  1. Configuration menu
    Copy the full SHA
    dd44d14 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    a86d113 View commit details
    Browse the repository at this point in the history

Commits on Sep 22, 2016

  1. Clarify SVD documentation

    Andlon committed Sep 22, 2016
    Configuration menu
    Copy the full SHA
    01013a6 View commit details
    Browse the repository at this point in the history
  2. Implement temporary Epsilon trait

    The idea is to remove this once epsilon() lands
    in the next version of the num crate.
    Andlon committed Sep 22, 2016
    Configuration menu
    Copy the full SHA
    677930e View commit details
    Browse the repository at this point in the history
  3. Add SVD benchmarks

    Since the benchmarks test module-internal methods,
    the benchmarks can not reside in the benches/ subdirectory.
    However, since the benchmarks must be run on nightly, it
    involves some complication. Hence, in order to run these
    benchmarks, you must add the 'nightly' feature to the compilation,
    like so:
    
    `cargo bench --features nightly`
    Andlon committed Sep 22, 2016
    Configuration menu
    Copy the full SHA
    d227259 View commit details
    Browse the repository at this point in the history

Commits on Sep 23, 2016

  1. Remove 'nightly' benchmarking of internal modules

    Instead just bench the public .svd() method along
    with the other benchmarks.
    Andlon committed Sep 23, 2016
    Configuration menu
    Copy the full SHA
    1e0f7a7 View commit details
    Browse the repository at this point in the history

Commits on Sep 24, 2016

  1. Configuration menu
    Copy the full SHA
    6a49d87 View commit details
    Browse the repository at this point in the history