ability to add members by searching for their names #2272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dvir Guttman <dvir.guttman@verizonmedia.com>
dvirguttman
force-pushed
the
user_search
branch
from
bebef12
to
ecf2d2f
Compare
abvaidya
reviewed
Aug 13, 2023
Signed-off-by: Dvir Guttman <dvir.guttman@verizonmedia.com>
royelbaum
reviewed
Aug 15, 2023
added 3 commits
August 17, 2023 17:00
Signed-off-by: Dvir Guttman <dvir.guttman@verizonmedia.com>
Signed-off-by: Dvir Guttman <dvir.guttman@verizonmedia.com>
| @@ -77,5 +81,26 @@ function refreshUserData(config, extServiceClient) { | |||
| }); | |||
| } | |||
|
|
|||
| async function readUsersFileFromDisk(fileName) { | |||
There was a problem hiding this comment.
couldn't find use of this function, should it be removed?
There was a problem hiding this comment.
it allows alternative way to load user file from disk, to be used by local development (for example vzm-ui)
added 2 commits
August 21, 2023 09:15
Signed-off-by: Dvir Guttman <dvir.guttman@verizonmedia.com>
Signed-off-by: Dvir Guttman <dvir.guttman@verizonmedia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.