Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix review group page error with expiry settings #2289

Merged
merged 1 commit into from
Aug 30, 2023

Conversation

jimmytsang
Copy link
Contributor

@jimmytsang jimmytsang commented Aug 30, 2023

Seems like we forgot to include timeZone={this.props.timeZone} in one of the components which was causing the issue in group page -> review tab when users have some defined expiry data

https://github.com/AthenZ/athenz/blob/master/ui/src/components/review/ReviewRow.js#L88

// this fn was getting passed undefined

this.localDate.getLocalDate(
    member.expiration,
    this.props.timeZone,
    this.props.timeZone
)

Signed-off-by: jtsang01 <jimmy.tsang@yahooinc.com>
@jimmytsang
Copy link
Contributor Author

ideally we have functional test to catch these kinds of errors, need to prioritize fixing/adding functional tests in the future.

@havetisyan havetisyan merged commit 5a18980 into AthenZ:master Aug 30, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants