libs/go/zmscli: fix dropped errors #2301
Conversation
libs/go/zmscli/import.go
Outdated
| @@ -166,6 +166,9 @@ func (cli Zms) importRoles(dn string, lstRoles []*zms.Role, existingRoles *zms.R | |||
| } | |||
| } | |||
| _, err = cli.AddRoleMembers(dn, rn, roleMembers) | |||
| if err != nil { | |||
There was a problem hiding this comment.
this check here is not correct. we already handle the error on line 185 where we check if we should report errors or not.
There was a problem hiding this comment.
This error is unhandled, as a new err is created inside the if block on 152 when := is used.
athenz/libs/go/zmscli/import.go
Line 152 in 47a7734
There was a problem hiding this comment.
The correct fix here would be to define adminRole as a local variable and replace := with just = so we don't create a new err variable and mask the one from outside the if block.
libs/go/zmscli/import.go
Outdated
| @@ -234,6 +237,9 @@ func (cli Zms) importRolesOld(dn string, lstRoles []interface{}, validatedAdmins | |||
| } | |||
| } | |||
| _, err = cli.AddRoleMembers(dn, rn, roleMembers) | |||
| if err != nil { | |||
There was a problem hiding this comment.
this check here is not correct. we already handle the error on line 253 where we check if we should report errors or not.
There was a problem hiding this comment.
This err is declared inside the if block when := is used, and is lost before the check on 253.
athenz/libs/go/zmscli/import.go
Line 222 in 47a7734
Signed-off-by: Lars Lehtonen <lars.lehtonen@gmail.com>
This fixes three dropped
errvariables in thelibs/go/zmsclipackage.