Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix service tags tab hiding other tabs #2361

Conversation

jimmytsang
Copy link
Contributor

@jimmytsang jimmytsang commented Oct 18, 2023

Description

Problem: currently selecting the service tags tab results in all other service tabs (static instances / dynamic instances / microsegmentation ) hidden.
Solution: feature flag on -> show all tabs, feature flag off -> show only tags tab

Contribution Checklist:

  • The pull request does not introduce any breaking changes
  • I have read the contribution guidelines.
  • Create an issue and link to the pull request.

jtsang01 added 2 commits October 18, 2023 14:25
Signed-off-by: jtsang01 <jimmy.tsang@yahooinc.com>
Signed-off-by: jtsang01 <jimmy.tsang@yahooinc.com>
@jimmytsang jimmytsang changed the title Remove feature flag hiding service instances tab Fix service tags tab hiding other tabs Oct 19, 2023
@abvaidya abvaidya merged commit fa4ebb4 into AthenZ:master Oct 23, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants