Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fetch verification key from server during access token validation for 1.10.x-jetty9 #2369

Conversation

RikuyaMatsumura
Copy link
Contributor

Description

I would like to incorporate the #2323 changes into 1.10.x-jetty9 branch.

Contribution Checklist:

  • The pull request does not introduce any breaking changes
  • I have read the contribution guidelines.
  • Create an issue and link to the pull request.

Attach Screenshots (Optional)

Signed-off-by: Rikuya Matsumura <rmatsumu@lycorp.co.jp>
@havetisyan
Copy link
Collaborator

@RikuyaMatsumura I don't see the changes for the ZPE client that were part of #2323. You weren't interested in the updated zpe library?

Signed-off-by: Rikuya Matsumura <rmatsumu@lycorp.co.jp>
@RikuyaMatsumura
Copy link
Contributor Author

Thanks for the review.
I made the changes to the ZPE client in 2eabe14.
I would appreciate it if you could review it again.

@RikuyaMatsumura
Copy link
Contributor Author

@havetisyan
Could you please review this?
I would greatly appreciate it.

@havetisyan havetisyan merged commit e0f38cf into AthenZ:1.10.x-jetty9 Nov 14, 2023
1 check passed
@RikuyaMatsumura RikuyaMatsumura deleted the feat/update-publickeymap-1.10.x branch November 14, 2023 01:26
@TakuyaMatsu
Copy link
Contributor

@havetisyan
Could you please release this?

@havetisyan
Copy link
Collaborator

havetisyan commented Nov 16, 2023

Sure. I’ll update some of the dependencies first and then release a new version in a day or two.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants