Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

simplify expiry notification lookups #2439

Merged
merged 1 commit into from
Nov 30, 2023
Merged

simplify expiry notification lookups #2439

merged 1 commit into from
Nov 30, 2023

Conversation

havetisyan
Copy link
Collaborator

@havetisyan havetisyan commented Nov 30, 2023

Description

we're addressing 2 issues with this simplification:
a) bug fix: with consolidated email where we only generate notifications once a day, it conflicts with metric notifications which also uses the same attribute and if we generate a metric notification, we might skip the email notification. So now we just use the same list of expired members to generate both email and metric notifications

b) remove the logic where the member has both expiration and review reminder options enabled, start notifications with the review reminder date. most of the users unknowingly set both to the same value and end up with no notifications. Now, that we're generating consolidated notifications, the issue with getting too many emails a day is no longer an issue so no need for extra logic.

Contribution Checklist:

  • The pull request does not introduce any breaking changes
  • I have read the contribution guidelines.
  • Create an issue and link to the pull request.

Attach Screenshots (Optional)

Signed-off-by: Henry Avetisyan <hga@yahooinc.com>
@havetisyan havetisyan merged commit 28ab99c into master Nov 30, 2023
2 checks passed
@havetisyan havetisyan deleted the expiry-notf branch November 30, 2023 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants