simplify expiry notification lookups #2439
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
we're addressing 2 issues with this simplification:
a) bug fix: with consolidated email where we only generate notifications once a day, it conflicts with metric notifications which also uses the same attribute and if we generate a metric notification, we might skip the email notification. So now we just use the same list of expired members to generate both email and metric notifications
b) remove the logic where the member has both expiration and review reminder options enabled, start notifications with the review reminder date. most of the users unknowingly set both to the same value and end up with no notifications. Now, that we're generating consolidated notifications, the issue with getting too many emails a day is no longer an issue so no need for extra logic.
Contribution Checklist:
Attach Screenshots (Optional)