-
-
Notifications
You must be signed in to change notification settings - Fork 374
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Subscribe to feed, java.sql.BatchUpdateException Incorrect datetime value: '1970-01-01 00:00:00' for column rss
.FEEDS
.disabledUntil
at row 1
#1239
Comments
Thanks, I can confirm there's an issue, mysql/mariadb TIMESTAMP column seems to start at |
I just released 4.3.0 that should fix this. |
Awesome. Updated and confirmed this is resolved ❤️ |
The adjusted time still causes problems on my system using MariaDB 10.11.6 and commafeed 4.3.0:
I believe this is timezone-related, because MariaDB's The largest positive UTC offset in use is UTC+14, so the earliest timestamp that's safe to use in all time zones is |
As a temporary hack, setting my MariaDB time zone to UTC does fix the issue: |
I read the documentation of MariaDB (https://mariadb.com/kb/en/about-mariadb-connector-j/#timezone-consideration) and here's what I understand: This is why the "Data truncation" error occurs, CommaFeed tries to set the disabledUntil field to 1970-01-01 00:00:01" but MariaDB applies an offset and the timestamp is now in an invalid range for the field. I think this is what needs to change:
|
Those changes seem okay to me; I've set the timezone in my database URL and that appears to behave nicely, but also adjusting the minimum time to not fail on databases which are configured differently from expected would be nice. |
Describe the bug
When attempting to subscribe to a feed via the web UI (page with the Subscribe button), I get the following error message:
Looking at the logs, I see the following:
Environment (please complete the following information):
The text was updated successfully, but these errors were encountered: