Create ToS and Privacy Statement #40
Conversation
AtilioA
added
enhancement
|
(Rebased to fix commits messages) |
| description: 'Ocorreu um erro ao fazer login. Cheque suas credenciais.' | ||
| }); | ||
| type: 'error', | ||
| title: 'Erro na autenticação', |
There was a problem hiding this comment.
"Verifique seu e-mail" may wrongly direct the user to check it's inbox . Just "Verifique suas credenciais" looks fine to me, since login user are also part of credentials, ana not only password
There was a problem hiding this comment.
Currently, the toast message is the same whether the credentials are incorrect or the user has not confirmed their email yet, thus the request.
web/src/pages/SignUp/index.tsx
Outdated
| @@ -35,10 +35,12 @@ const SignUp: React.FC = () => { | |||
| (password: string, field: any) => | |||
| password | |||
| ? field | |||
| .required('Senhas não batem') | |||
| .oneOf([Yup.ref('password')], 'Senhas não batem') | |||
| .required('Senhas não batem') | |||
There was a problem hiding this comment.
"Senhas não são iguais"
There was a problem hiding this comment.
Unrelated to PR but will change
| description: 'Ocorreu um erro ao fazer login. Cheque suas credenciais.' | ||
| }); | ||
| type: 'error', | ||
| title: 'Erro na autenticação', |
There was a problem hiding this comment.
Currently, the toast message is the same whether the credentials are incorrect or the user has not confirmed their email yet, thus the request.
web/src/pages/SignUp/index.tsx
Outdated
| @@ -35,10 +35,12 @@ const SignUp: React.FC = () => { | |||
| (password: string, field: any) => | |||
| password | |||
| ? field | |||
| .required('Senhas não batem') | |||
| .oneOf([Yup.ref('password')], 'Senhas não batem') | |||
| .required('Senhas não batem') | |||
There was a problem hiding this comment.
Unrelated to PR but will change
Creates ToS.md file with ToS and Privacy Statement. Reads the markdown file with
markdown-to-jsx(I've triedreact-markdownbut had trouble with types) and displays its content on the/privacidadepage, properly stylized.Somewhat out of scope for this issue-PR, I'll add a checkbox to the SignUp as well (edit: done).
Resolves #36.