Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved setup docs #116

Merged
merged 4 commits into from
Aug 2, 2023
Merged

Improved setup docs #116

merged 4 commits into from
Aug 2, 2023

Conversation

Caeden117
Copy link
Contributor

Starting this PR a little early. Documentation may not be as fleshed out as whats needed for proper deployment, hopefully some good reviews would point that out.

This PR introduces new setup documentation for Hive, as well as the following:

  • Modified Dockerfile to pull in the new HiveCorePlugins docker image.
    • This should allow anyone to deploy Hive using Docker / Docker Compose without needing to manually download and set up Hive core plugins.
  • Modified docker-compose.yml with more comments and examples for volume mounting and plugin configuration.

@Caeden117 Caeden117 requested review from Auros and a team as code owners August 1, 2023 03:21
- /path/to/rules:/app/Rules

# Where external Hive plugins will be loaded from
#- /path/to/hive/plugins:/app/plugins
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commented intentionally?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct. HiveCorePlugins is already included in the Hive docker image, so mounting the plugins folder is only necessary if the administrator wants to load third party plugins.


If you do not want to use Docker, you can download the latest release of Hive through [the Releases page](https://github.com/Atlas-Rhythm/Hive/releases).

Simply unzip the Hive release wherever you wish to host Hive.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you also need plugins for this? Or do the releases have plugins bundled with them?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If not, might be nice to clarify

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think ideally, when we do go to make releases, we'd want to bundle HiveCorePlugins into the release zip. A major pain point in deployment right now is having to manually download and install the HiveCorePlugins to even use Hive, so I believe bundling core plugins wherever possible is a good idea.

@Caeden117 Caeden117 merged commit 16f5b83 into master Aug 2, 2023
2 checks passed
@Caeden117 Caeden117 deleted the caeden/the-setup-docs branch August 2, 2023 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants