Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure preferred common name is identical on search results and species page #3

Open
charvolant opened this issue Apr 6, 2022 · 6 comments
Assignees
Milestone

Comments

@charvolant
Copy link
Contributor

For example https://bie.ala.org.au/search?sortField=score&dir=desc&q=Bellis+perennis gives 'English Daisy' but https://bie.ala.org.au/species/https://id.biodiversity.org.au/node/apni/2888214#overview gives 'Daisy'.

@Rita-C Rita-C self-assigned this May 4, 2022
@adam-collins
Copy link
Contributor

This fix is included with the new names index that is in development.

@adam-collins
Copy link
Contributor

There is a change in expectations. The common name that the BIE and namematching return will not be the same, just less random.

@adam-collins adam-collins assigned adam-collins and unassigned Rita-C Jan 29, 2024
adam-collins pushed a commit that referenced this issue Jan 29, 2024
@adam-collins adam-collins added this to the 4.2.0 milestone Jan 29, 2024
adam-collins added a commit that referenced this issue Apr 1, 2024
@adam-collins
Copy link
Contributor

I think there needs to be a change to the species page as well as it is using a different method to source the common name and can display multiple common names.

commonNameSingle, at least, should appear on the species page to be more consistent. https://bie-test.ala.org.au/search?q=https://id.biodiversity.org.au/taxon/apni/51437865

@adam-collins
Copy link
Contributor

This is up on test. Now using commonNameSingle consistently on the search result and show page. This issue is now waiting on bie-index vernacular name sync with namematching-ws.

@adam-collins
Copy link
Contributor

See the linked issue for testing details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants