Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sanitise EOL HTML #200

Closed
Rita-C opened this issue Jan 12, 2020 · 3 comments
Closed

Sanitise EOL HTML #200

Rita-C opened this issue Jan 12, 2020 · 3 comments
Assignees
@Rita-C
Labels
enhancement IAD

Comments

@Rita-C
Copy link
Contributor

Rita-C commented Jan 12, 2020 •
edited
Loading

Ticket split from #195

Suggest we sanitise EOL HTML and remove inline CSS, that also creeps into some pages (example). Biocache uses org.apache.commons.lang.StringEscapeUtils.unescapeHtml() to do this (see code).
Rita-C added a commit that referenced this issue Jan 15, 2020
@Rita-C
#200 Sanitise EOL HTML.
bdb22fb
Rita-C added a commit to AtlasOfLivingAustralia/ala-install that referenced this issue Jan 15, 2020
@Rita-C
Change for AtlasOfLivingAustralia/bie-plugin#200 Sanitise EOL HTML.
db2f755
@Rita-C
Copy link
Contributor Author

Rita-C commented Jan 15, 2020

https://upsource.ala.org.au/bie-plugin/review/BP-CR-4.

@Rita-C Rita-C self-assigned this Jan 16, 2020
@Rita-C
Copy link
Contributor Author

Rita-C commented Jan 16, 2020

@nickdos , could you review the fix please?

Rita-C added a commit that referenced this issue Jan 17, 2020
@Rita-C
#200 Sanitise EOL HTML. Added test case.
3a8af2c
Rita-C added a commit that referenced this issue Jan 20, 2020
@Rita-C
Merge pull request #201 from AtlasOfLivingAustralia/develop
678029f 
Fixes for #195 and #200
@TaniaGLaity
Copy link

see comments above - closed issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Rita-C Rita-C

Labels
enhancement IAD
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Rita-C @TaniaGLaity