This repository has been archived by the owner on Aug 7, 2023. It is now read-only.
Fix exception for "Fix File" on Windows #354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch fixes the exception raised applying "Fix File" command.
It doesn't follow the disruptive suggestion to assimilate on('FIX' to on('JOB' , because there are too much IF statements.
Maybe we can refactor the listeners later and in another way.
Closes #353
Fix linter error.
|
LGTM |
|
LGTM as well, merging and thanks! |
Arcanemagus
added a commit
that referenced
this pull request
Dec 7, 2015
Fix exception for "Fix File" on Windows
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch fixes the exception raised applying "Fix File" command.
It doesn't follow the disruptive suggestion to assimilate on('FIX' to on('JOB' , because there are too much IF statements.
Maybe we can refactor the listeners later and in another way.
Closes #353