This repository has been archived by the owner on Aug 7, 2023. It is now read-only.
Check that configFile is string #358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should also add this check down in the fixer job. |
* Check that `configFile` is a string before calling `resolveEnv` on it Closes AtomLinter#356
SpainTrain
force-pushed
the
356-fix-configfile-check
branch
from
ca408a8
to
0aba191
Compare
👍 ✅ |
|
Reviewed 1 of 1 files at r1. Comments from the review on Reviewable.io |
|
LGTM assuming CI passes. |
|
Wow, for once Travis was the first to complete. |
|
Same change for on('FIX' part? |
|
@albertosantini already in the PR, maybe you need to refresh your page? |
|
Yep, sorry for the noise. :) |
|
CI is good, merging since @SpainTrain assigned it to me for some reason 😛. |
Arcanemagus
added a commit
that referenced
this pull request
Dec 7, 2015
Check that configFile is string
That reason is laziness |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
configFileis a string before callingresolveEnvon itCloses #356