Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove TransactionalSupport as a Service dependency #15

Open
morihladko opened this issue Jan 23, 2017 · 0 comments
Open

Remove TransactionalSupport as a Service dependency #15

morihladko opened this issue Jan 23, 2017 · 0 comments
Labels
enhancement

Comments

@morihladko
Copy link
Collaborator

Not all services need db support Service class should not have a TransactionalSupport as dependency. There could a separate DbService or TransactionalSupport can be done as a decorator/mixin,
morihladko added a commit that referenced this issue Jan 25, 2017
@morihladko
Remove SqlSessionMixin
8f99b0b 
I removed the SqlSessionMixin because of redundancy with
TransactionalSupport class, which Martin Babka added as dependency in
Service. My original intention was not add as a direct ancestor to
Serivce and have more like a mixin.

I still think that having a plain Service (without dependencies) would
be better, not all services needs DB access.

See #15
@JankesJanco JankesJanco mentioned this issue Nov 9, 2017
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@morihladko