Distribute IVAN.dmg for MacOS and Fix icon for IVAN.app #525

jakwings · 2019-01-18T12:18:39Z

No description provided.

jakwings · 2019-01-18T12:28:46Z

Wait a minute...

jakwings · 2019-01-18T14:14:22Z

Done. Download link (will expire someday) https://github.com/jakwings/ivan/releases/download/vTest/IVAN-vTest-osx.dmg

andrewtweber · 2019-01-18T23:54:58Z

Oooh nice. I'm glad we can set the icon on it. I'm seeing a white background though, is there any way to get a transparent background? Worst case scenario then red would be preferred over white.

Also pretty fuzzy. I can provide a higher resolution graphic if you tell me what size and format it should be.

Which icon would everybody prefer, the pixelated one or the more realistic one?

jakwings · 2019-01-20T01:23:10Z

like this?

jakwings · 2019-01-20T01:29:24Z

PNG format is okay. Are you suggesting a new icon for all platforms? The sizes needed for making an icon.icns file on mac are 16, 32, 64, 128, 256, 512, 1024. The realistic one is nice.

AlexMooney · 2019-01-29T16:47:47Z

When this is merged, can we get a new point release?

ryfactor · 2019-01-29T20:05:00Z

When this is merged, can we get a new point release?

Yep sure thing :)

andrewtweber · 2019-01-29T23:17:05Z

Without shadow

andrewtweber · 2019-01-29T23:18:40Z

As much as I'd like the realistic one, I don't think the quality will look good for > 128px or < 64px so we should probably stick with the classic. I'll leave it up to your judgement if it looks better with or without shadow

andrewtweber · 2019-01-30T06:12:06Z

In hindsight it makes no sense for the shadow itself to be pixelated. So here's an updated version with the shadow.

jakwings · 2019-01-31T12:35:54Z

Could the shadow be lighter?

Although the banana looks smaller now and has a glow/blur effect, it is still too large when compared to the pickaxe. I prefer the completely solid one.

Then I tried to enlarge the realistic one to 256x256 (128x128@2x) with https://waifu2x.booru.pics/
It looks pretty good even when the Dock size is set to the largest.

The icns has been pushed to ci/osx/IVAN.app/Contents/Resources/realistic.icns
512x512 and 1024x1024 are not included since I'm not sure when they would be used.

The latest dmg: (icon is not dynamically set to the Icon.bmp when run)
https://github.com/jakwings/ivan/releases/download/vTest2/IVAN-vTest2-osx.dmg

jakwings · 2019-01-31T12:59:58Z

and the one using the realistic icon: https://github.com/jakwings/ivan/releases/download/vTest3/IVAN-vTest3-osx.dmg

andrewtweber · 2019-02-07T15:17:05Z

After seeing both of them in action I think I prefer the pixelated one actually.

I do think it needs a bit of a shadow, I'll get you a copy of the icon with less shadow

I'll post a "poll" on the forum after the pixelated version is finalized

andrewtweber · 2019-02-13T01:01:11Z

How is this?

jakwings · 2019-02-14T11:04:42Z

Yeah, I have no problem with the one with less shadow.

+1 for both the pixelated & the realistic.

now I know that 512x512 (256x256@2x) is for the Finder pop-up window for preview

jakwings · 2019-02-14T14:12:27Z

Two demos for trying out the icons: https://ipfs.io/ipfs/QmQtxPa5PGQE1FZCQMWrTQLFF6RWmopvjNeUFGPSAvC1Rw

Demo.app/
└── Contents/
    ├── Info.plist
    ├── MacOS/
    │   └── play
    ├── PkgInfo
    └── Resources/
        └── ivan.icns

andrewtweber · 2019-02-14T18:01:05Z

Added a poll here:

https://attnam.com/topics/Preferred-icon-for-game-releases

andrewtweber · 2019-02-15T15:58:10Z

@iology it's overwhelmingly in favor of keeping the pixelated icon (only 5 votes but.. that's about all we can hope for). Also sounds like the modern one may have been specifically made for the website. Let's go with pixelated.

The icon was not shown because there was a directory "ivan" with the same basename as the icon file "ivan.icns". Set the extension .icns explicitly to resolve the issue.

Use a pixelated icon with shadow and transparent background.

jakwings · 2019-02-15T21:17:20Z

Rebased and cleaned up the commit messages.

So this icon is for all platforms. Note that this is a PR for mac only.

andrewtweber · 2019-02-16T22:30:58Z

Looks good to merge but I'll let @fejoa take a look first as well as see what needs to be done for Windows icon to match with the slight shadow

ryfactor · 2019-02-17T22:27:43Z

@andrewtweber excellent, I'll look into it. What are your settings for the drop shadow?

andrewtweber · 2019-02-17T23:39:34Z

Oof I don't remember.

What format does Windows use, ICO?

Any way to just combine the PNGs above into layers? Or does it need a size that we don't have

ryfactor · 2019-02-18T00:35:58Z

Yep Windows just uses the ICO format. I just save your 256x256 png and open it in GIMP. Using GIMP I can create a variety of sizes from the largest windows size (256x256). For some reason the drop shadow goes away, but I can set it up again in GIMP and it will be preserved in the export to the .ico format.

EDIT: Almost got something working, just need the info about the drop shadow. Preferable an x-offset, y-offset, blur radius and opacity, all measured in pixels... 😨

andrewtweber · 2019-02-18T05:21:29Z

Hmm, you should be able to just paste the individual files above as layers. Does this work?

https://drive.google.com/file/d/1HFo7XGudu5LUeS4vzOk2jF31oA8XPBh4/view?usp=sharing

ryfactor · 2019-02-18T09:44:30Z

Thanks Andrew, I'll download those tomorrow and make the ICO.

andrewtweber · 2019-02-18T14:01:35Z

The google drive file I linked to in the previous comment is an ICO :) Has all sizes from 16x16 to 256x256. Should’ve just made it for you in the first place

ryfactor · 2019-02-18T20:45:38Z

Excellent, thanks Andrew. I did open it for a look and found it didn't have the 48x48 pixel size needed for windows, so I added that in. It seems like the drop shadow has been preserved throughout the processing.

I added the ICO file in #533. In a hideous twist, it seems like Windows caches the old icon, so existing players might not see the updated icon if they add a shortcut to IVAN for example to their desktop folder. If they access IVAN from its own folder, then I think it will simply display our new icon :)

EDIT: Since the new ICO has the same name as the old, no further changes are needed to Ivan.rc. The build system will therefore take care of everything.

ryfactor mentioned this pull request Feb 14, 2019

Crashes on open #523

Open

J.W added 5 commits February 16, 2019 05:08

Fix icon for mac app

d1715e9

The icon was not shown because there was a directory "ivan" with the same basename as the icon file "ivan.icns". Set the extension .icns explicitly to resolve the issue.

Do not dynamically change the Dock icon for mac app

a9ba37e

Update the icon for mac app

9898709

Use a pixelated icon with shadow and transparent background.

Distribute mac app in dmg file

446837c

Try to reduce CI build time for mac

2c5247e

andrewtweber merged commit 93efe67 into Attnam:master Feb 18, 2019

jakwings mentioned this pull request Feb 6, 2020

Add full PNG iconset #578

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Distribute IVAN.dmg for MacOS and Fix icon for IVAN.app #525

Distribute IVAN.dmg for MacOS and Fix icon for IVAN.app #525

jakwings commented Jan 18, 2019

jakwings commented Jan 18, 2019

jakwings commented Jan 18, 2019

andrewtweber commented Jan 18, 2019 •

edited

Loading

jakwings commented Jan 20, 2019

jakwings commented Jan 20, 2019

AlexMooney commented Jan 29, 2019

ryfactor commented Jan 29, 2019

andrewtweber commented Jan 29, 2019

andrewtweber commented Jan 29, 2019 •

edited

Loading

andrewtweber commented Jan 30, 2019

jakwings commented Jan 31, 2019

jakwings commented Jan 31, 2019

andrewtweber commented Feb 7, 2019 •

edited

Loading

andrewtweber commented Feb 13, 2019

jakwings commented Feb 14, 2019

jakwings commented Feb 14, 2019

andrewtweber commented Feb 14, 2019

andrewtweber commented Feb 15, 2019

jakwings commented Feb 15, 2019

andrewtweber commented Feb 16, 2019

ryfactor commented Feb 17, 2019

andrewtweber commented Feb 17, 2019 •

edited

Loading

ryfactor commented Feb 18, 2019 •

edited

Loading

andrewtweber commented Feb 18, 2019

ryfactor commented Feb 18, 2019

andrewtweber commented Feb 18, 2019 •

edited

Loading

ryfactor commented Feb 18, 2019 •

edited

Loading

Distribute IVAN.dmg for MacOS and Fix icon for IVAN.app #525

Distribute IVAN.dmg for MacOS and Fix icon for IVAN.app #525

Conversation

jakwings commented Jan 18, 2019

jakwings commented Jan 18, 2019

jakwings commented Jan 18, 2019

andrewtweber commented Jan 18, 2019 • edited Loading

jakwings commented Jan 20, 2019

jakwings commented Jan 20, 2019

AlexMooney commented Jan 29, 2019

ryfactor commented Jan 29, 2019

andrewtweber commented Jan 29, 2019

andrewtweber commented Jan 29, 2019 • edited Loading

andrewtweber commented Jan 30, 2019

jakwings commented Jan 31, 2019

jakwings commented Jan 31, 2019

andrewtweber commented Feb 7, 2019 • edited Loading

andrewtweber commented Feb 13, 2019

jakwings commented Feb 14, 2019

jakwings commented Feb 14, 2019

andrewtweber commented Feb 14, 2019

andrewtweber commented Feb 15, 2019

jakwings commented Feb 15, 2019

andrewtweber commented Feb 16, 2019

ryfactor commented Feb 17, 2019

andrewtweber commented Feb 17, 2019 • edited Loading

ryfactor commented Feb 18, 2019 • edited Loading

andrewtweber commented Feb 18, 2019

ryfactor commented Feb 18, 2019

andrewtweber commented Feb 18, 2019 • edited Loading

ryfactor commented Feb 18, 2019 • edited Loading

andrewtweber commented Jan 18, 2019 •

edited

Loading

andrewtweber commented Jan 29, 2019 •

edited

Loading

andrewtweber commented Feb 7, 2019 •

edited

Loading

andrewtweber commented Feb 17, 2019 •

edited

Loading

ryfactor commented Feb 18, 2019 •

edited

Loading

andrewtweber commented Feb 18, 2019 •

edited

Loading

ryfactor commented Feb 18, 2019 •

edited

Loading