Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add full PNG iconset #578

Merged
merged 2 commits into from Mar 1, 2020
Merged

Add full PNG iconset #578

merged 2 commits into from Mar 1, 2020

Conversation

ghost
Copy link

@ghost ghost commented Jan 29, 2020

I added a desktop item to ivan package in NixOS (created and maintained by me).

However, an icon in PNG format is required, BMP is not an option.
Thus, an icon must be created during the package building process using GraphicsMagic.

I think it would be nice to add a png icon to your upstream to make things easier.
In addition, it can be useful for other users, developers and maintainers (I hope so).
This one (icon.png) is converted using GraphicsMagick from Item.bmp.

👽

@ghost
Copy link
Author

ghost commented Feb 5, 2020

@iology @fejoa @red-kangaroo What do you think? 👽

@jakwings
Copy link
Member

jakwings commented Feb 6, 2020

Also consider the shadowed&shadowless icons in this zipball: https://api.ipfsbrowser.com/ipfs/download.php?hash=QmdQ1rHHHTbgbGorfuMMYDQQ36q4sxvYcB4GDEHREuJQkL (Source: #525)

@ghost
Copy link
Author

ghost commented Feb 10, 2020

It seems that your link is returning a text file, not a zipball (at least for me) 😯
Perhaps I can use the icons from @andrewtweber ?
I may also create a separate directory, because there are a lot of them 👽

@ryfactor
Copy link
Member

@freepotion this is great. I guess you can use the icons by @andrewtweber, or ones based on them. If you need a new directory, then that is cool.

@jakwings
Copy link
Member

jakwings commented Feb 10, 2020

It seems that your link is returning a text file, not a zipball (at least for me) 😯
Perhaps I can use the icons from @andrewtweber ?
I may also create a separate directory, because there are a lot of them 👽

The link expired so fast... Now it is uploaded to github directly:
ivan-icns.zip

md5sum: f11441b326d1cf0db3a7d7e295979287
sha256sum: 050bb1934b13b4764e3b371aebbf1a4ea6db891e8a1a1f553953950e312f34b1

@ghost
Copy link
Author

ghost commented Feb 10, 2020

@fejoa Thanks! I decided to use the archive from @iology, since there is already everything that is needed there. 👽
@iology Thank you, this archive is just what we need! I removed my icon and added yours. 👽

@ghost ghost changed the title Add icon.png (converted from Item.bmp) Add full PNG iconset Feb 13, 2020
@ryfactor
Copy link
Member

@freepotion is this ready to be merged?

@ghost
Copy link
Author

ghost commented Mar 1, 2020

@fejoa Yes, I think so (if there is no objection to the names of directories) 👽

@ryfactor ryfactor merged commit 3cad99d into Attnam:master Mar 1, 2020
@ghost
Copy link
Author

ghost commented Mar 2, 2020

@fejoa Thanks! 👽

@ghost ghost mentioned this pull request Mar 19, 2020
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants