Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.8.5 #246

Merged
merged 57 commits into from
Aug 21, 2020
Merged

2.8.5 #246

merged 57 commits into from
Aug 21, 2020

Commits on May 17, 2020

  1. Bundle QtApng on Windows

    oldmud0 committed May 17, 2020
    Configuration menu
    Copy the full SHA
    dbde914 View commit details
    Browse the repository at this point in the history

Commits on May 18, 2020

  1. Configuration menu
    Copy the full SHA
    c9b9822 View commit details
    Browse the repository at this point in the history

Commits on May 19, 2020

  1. Configuration menu
    Copy the full SHA
    bc4fd2b View commit details
    Browse the repository at this point in the history
  2. CI: Fix YAML syntax error

    oldmud0 committed May 19, 2020
    Configuration menu
    Copy the full SHA
    4f8367b View commit details
    Browse the repository at this point in the history
  3. CI: Update Dockerfile

    oldmud0 committed May 19, 2020
    Configuration menu
    Copy the full SHA
    8989c4f View commit details
    Browse the repository at this point in the history

Commits on May 20, 2020

  1. Configuration menu
    Copy the full SHA
    7754175 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    2cf5a04 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    8a4d5e8 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    5a023e3 View commit details
    Browse the repository at this point in the history

Commits on Aug 4, 2020

  1. Configuration menu
    Copy the full SHA
    07e1127 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    6305180 View commit details
    Browse the repository at this point in the history

Commits on Aug 5, 2020

  1. Fix not using custom chatbox's colors (#228)

    * Fix not using custom chatbox's colors
    
    Moved set_text_color_dropdown() to after current_char is actually updated
    with the selected char. Otherwise set_text_color_dropdown will try to
    update the colors with either nothing as character, or with the previously
    selected character.
    
    Use get_chat() so it actually gets the name of the custom chatbox
    instead of using the same name as the character.
    Remove the extra "c" since get_chat_color it's already called
    with this "c" in place.
    
    * Fix previous fix crashing the client on DRO servers
    
    For some reason the client would work just fine
    if set_text_color_dropdown() was called only once
    after updating the character selected by the user.
    But when joining a DRO server the client would crash
    just before loading the music.
    
    * Improve comment with where crash happens
    
    * Fix get_chat_markdown to get the custom chatbox on misc of the char
    
    instead of trying to find the character folder on misc
    
    * Fix client using the current character colors on other people's messages
    
    Also remove the comment explaining the crash if set_text_color_dropdown
    is removed from set_widgets
    
    * Fix loading custom colors loading after the message was added to the log
    likeawindrammer committed Aug 5, 2020
    Configuration menu
    Copy the full SHA
    0ce60d6 View commit details
    Browse the repository at this point in the history

Commits on Aug 6, 2020

  1. Update Russian translation (excl. courtroom UI) (#239)

    Edited TL, added TL for tool tips and other untranslated strings.
    Courtroom UI elements were left in English to avoid cropping.
    schastev committed Aug 6, 2020
    Configuration menu
    Copy the full SHA
    b04b22b View commit details
    Browse the repository at this point in the history

Commits on Aug 13, 2020

  1. Configuration menu
    Copy the full SHA
    593e9d7 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    e88f885 View commit details
    Browse the repository at this point in the history

Commits on Aug 16, 2020

  1. Only regenerate the area list once per ARUP packet

    scatterflower committed Aug 16, 2020
    Configuration menu
    Copy the full SHA
    8b44d4a View commit details
    Browse the repository at this point in the history
  2. Create brushes for area list once

    scatterflower committed Aug 16, 2020
    Configuration menu
    Copy the full SHA
    102ca4d View commit details
    Browse the repository at this point in the history
  3. Check for custom realization sound when using effects list

    scatterflower committed Aug 16, 2020
    Configuration menu
    Copy the full SHA
    0020863 View commit details
    Browse the repository at this point in the history
  4. Ensure consistent behavior in IC log, clarify showname logic, and def…

    …ine constants for minimum and maximum packet sizes
    scatterflower committed Aug 16, 2020
    Configuration menu
    Copy the full SHA
    11250e1 View commit details
    Browse the repository at this point in the history
  5. Remove clientside doublepost checking

    scatterflower committed Aug 16, 2020
    Configuration menu
    Copy the full SHA
    079ce93 View commit details
    Browse the repository at this point in the history
  6. Merge pull request #245 from scatterflower/realization_fix

    Check for custom realization sound when using effects list
    mposs00 committed Aug 16, 2020
    Configuration menu
    Copy the full SHA
    3460474 View commit details
    Browse the repository at this point in the history
  7. Update brushes on theme reload

    scatterflower committed Aug 16, 2020
    Configuration menu
    Copy the full SHA
    cd3ddfe View commit details
    Browse the repository at this point in the history
  8. Merge pull request #244 from scatterflower/is241

    Optimize ARUP
    mposs00 committed Aug 16, 2020
    Configuration menu
    Copy the full SHA
    de6a2ba View commit details
    Browse the repository at this point in the history
  9. Clean up logic in handle_chatmessage()

    scatterflower committed Aug 16, 2020
    Configuration menu
    Copy the full SHA
    507180d View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    42d9396 View commit details
    Browse the repository at this point in the history
  11. Merge pull request #250 from scatterflower/boldfix

    Fix improper bolding behavior due to malformed string literal
    mposs00 committed Aug 16, 2020
    Configuration menu
    Copy the full SHA
    a316933 View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    5c6dad8 View commit details
    Browse the repository at this point in the history
  13. Merge pull request #1 from scatterflower/ic_fixes

    Ic fixes
    mposs00 committed Aug 16, 2020
    Configuration menu
    Copy the full SHA
    e546ead View commit details
    Browse the repository at this point in the history
  14. further cleanup of chat handler

    scatterflower committed Aug 16, 2020
    Configuration menu
    Copy the full SHA
    1c5b097 View commit details
    Browse the repository at this point in the history
  15. fix incorrect emote modifier

    scatterflower committed Aug 16, 2020
    Configuration menu
    Copy the full SHA
    95725eb View commit details
    Browse the repository at this point in the history
  16. fix check for negative char_id

    scatterflower committed Aug 16, 2020
    Configuration menu
    Copy the full SHA
    3c031db View commit details
    Browse the repository at this point in the history
  17. allow -1 charid for system messages

    scatterflower committed Aug 16, 2020
    Configuration menu
    Copy the full SHA
    4b7efc8 View commit details
    Browse the repository at this point in the history
  18. Merge pull request #251 from scatterflower/2.8

    Simplify parts of the IC handler, and fix some bugs
    mposs00 committed Aug 16, 2020
    Configuration menu
    Copy the full SHA
    89aa821 View commit details
    Browse the repository at this point in the history
  19. Don't hang IC due to invalid emote mod

    scatterflower committed Aug 16, 2020
    Configuration menu
    Copy the full SHA
    8712ed3 View commit details
    Browse the repository at this point in the history

Commits on Aug 17, 2020

  1. make suggested changes from code review

    scatterflower committed Aug 17, 2020
    Configuration menu
    Copy the full SHA
    c5f8fc8 View commit details
    Browse the repository at this point in the history
  2. Merge pull request #253 from scatterflower/2.8

    Don't hang IC due to invalid emote mod
    mposs00 committed Aug 17, 2020
    Configuration menu
    Copy the full SHA
    1bbfd71 View commit details
    Browse the repository at this point in the history
  3. use proper syntax to instansiate qbrush

    scatterflower committed Aug 17, 2020
    Configuration menu
    Copy the full SHA
    ae7c36e View commit details
    Browse the repository at this point in the history
  4. use shownames in log properly

    scatterflower committed Aug 17, 2020
    Configuration menu
    Copy the full SHA
    359cad7 View commit details
    Browse the repository at this point in the history
  5. clang format

    scatterflower committed Aug 17, 2020
    Configuration menu
    Copy the full SHA
    ecb0ee4 View commit details
    Browse the repository at this point in the history
  6. Merge pull request #254 from scatterflower/2.8

    2.8.5 finishing touches
    mposs00 committed Aug 17, 2020
    Configuration menu
    Copy the full SHA
    c24ecc3 View commit details
    Browse the repository at this point in the history
  7. Do not update colors in log for each IC message

    scatterflower committed Aug 17, 2020
    Configuration menu
    Copy the full SHA
    da00208 View commit details
    Browse the repository at this point in the history
  8. fix statement after break; from case

    scatterflower committed Aug 17, 2020
    Configuration menu
    Copy the full SHA
    4ada75a View commit details
    Browse the repository at this point in the history
  9. Merge pull request #255 from scatterflower/2.8

    Do not update colors in log for each IC message
    mposs00 committed Aug 17, 2020
    Configuration menu
    Copy the full SHA
    3c13a68 View commit details
    Browse the repository at this point in the history

Commits on Aug 18, 2020

  1. Improved blankposting (#256)

    * Consolidate blankposting into singular log entries of "no message" instead of spamming the logs repeatedly when someone decides to keep switching emotes
    Return proper blankpost checking to 2.8.5 (chatmessage_is_empty bool makes sure the chatbox doesn't appear - branch broke that behavior by never setting it)
    More robust blankpost checking, meaning that passing a competely empty "" string will also count as a blankpost
    Fix screenshake not working with blankposting by moving it before the chatmessage_is_empty check in start_chack_ticking() stage of the message parsing
    
    * Allow user to send blankposts without even having to input a single spacebar, but only if last m_chatmessage CID matches ours.
    
    * Reviews are cool and good:ok_hand:
    allow sending no-text chat message to server without weird cid checks (let the server validate if they want to do STR_OR_EMPTY or just STR) - doesn't break existing behavior and lets servers introduce the new one if they want to
    Treat all blank/whitespace messages as blankposting and not just single-whitespace.
    Remove chatmessage_is_empty bool because why the fuck would you even need it if you have m_chatmessage[MESSAGE] already
    Simplify chatlogpiece log entry to not be a *temp pointer by suggestion
    
    * another useless bool destroyed
    Make "additive" have a very awesome emergent behavior with blankposting - keep showing the chatbox+message while only changing the emotes. Works with preanims too!
    Crystalwarrior committed Aug 18, 2020
    Configuration menu
    Copy the full SHA
    475a572 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    76af6c0 View commit details
    Browse the repository at this point in the history
  3. CI: Build QtApng on Linux

    - Set lib as artifact instead of cache (to avoid race condition
      described in https://gitlab.com/gitlab-org/gitlab/-/issues/21409)
    - Delete _Unadapted folder and .git files when exporting artifact (yuck!
      should probably have never incorporated AO2-Themes as a separate
      repo; it should probably have stayed part of the vanilla repo.)
    oldmud0 committed Aug 18, 2020
    Configuration menu
    Copy the full SHA
    d10ad44 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    a9ca555 View commit details
    Browse the repository at this point in the history

Commits on Aug 19, 2020

  1. Configuration menu
    Copy the full SHA
    c984c57 View commit details
    Browse the repository at this point in the history
  2. IC log rewrite (#259)

    * Rewrite the IC Log code to drastically reduce code duplication and have both downward and upward mode in the same function
    Regenerate the IC Log in set_widgets() function, making sure the maximum_blocks is accounted for and clearing the log to prepare for different log mode (upwards/downwards) if it's different from previous
    Add placeholder text telling the user the direction in which the log will go
    Remove useless first_message_sent global boolean, a remnant from a   w e a k e r   c o d e r m a n
    
    * Add log_colors boolean to reduce color I/O happening in append_ic_text (optimization meme)
    Clear the IC log when log_colors setting changes and reload theme is pressed
    Fix #221
    
    * Add configurable margin between IC log entries
    Add configurable newline/singleline log mode
    Options in settings for these
    
    * Add optional timestamps
    
    * Un-hardcode "played music" from the chatlogpiece and introduce the "action" argument so that "presented evidence" is fully supported now
    Translate "has presented evidence"
    Regenerate IC chatlog instead of clearing it, properly updating every element with the new configurations
    
    * Go away *temp, code duplication making me shid and cry rn
    Why is this not done in append_ic_text, or why isn't there a dedicated ic logging func aAAAaaaaAAAaa
    Fix presenting evidence not being properly logged
    Fix timestamp being UTC instead of local time (local time will not be as confusing)
    
    * okok it was a joke a big ol bamboozle you got gnomed haha rick rolled beaned stickbugged
    I did NOT copy paste code, no, I actually intended to fix copy pasted code all along. log_ic_text was always planned.
    
    (Fix copypasted code for ic_chatlog_history and consolidate it into a single log_ic_text func)
    Crystalwarrior committed Aug 19, 2020
    Configuration menu
    Copy the full SHA
    cef0ebc View commit details
    Browse the repository at this point in the history
  3. Reset BASS when switching devices; drop Qt Multimedia support (#262)

    * Allow changing audio device on the fly while in a server
    * Use default audio device if device in config doesn't exist
    * Automatically change audio device to default when current one is invalid
    * Destroy Qt Multimedia support
    
    It was decided that there was not enough attention being given to Qt
    Multimedia support to justify its continued maintenance simply as a
    libre alternative to BASS. While substantial changes to audio were being
    made in 2.8, the Qt Multimedia support code fell behind in disrepair.
    It's clear that there is no vested interest in implementing audio
    features twice for the sake of licensing.
    
    When it's time to switch to another audio library, it will be done
    unilaterally.
    
    * CI: Use BASS for Linux build
    
    Co-authored-by: oldmud0 <oldmud0@users.noreply.github.com>
    mposs00 and oldmud0 committed Aug 19, 2020
    Configuration menu
    Copy the full SHA
    9eb0f53 View commit details
    Browse the repository at this point in the history

Commits on Aug 20, 2020

  1. version bump to 2.8.5

    scatterflower committed Aug 20, 2020
    Configuration menu
    Copy the full SHA
    7cd0fa0 View commit details
    Browse the repository at this point in the history
  2. Merge some various CI changes

    Most importantly, Linux now targets Qt 5.9.5 with a self-built version
    of QtApng, which should fix the Qt version issues.
    oldmud0 committed Aug 20, 2020
    Configuration menu
    Copy the full SHA
    5e1474f View commit details
    Browse the repository at this point in the history
  3. Update themes submodule

    oldmud0 committed Aug 20, 2020
    Configuration menu
    Copy the full SHA
    a7a33eb View commit details
    Browse the repository at this point in the history
  4. Rename serverlist.txt -> serverlist.sample.txt

    We don't want to accidentally overwrite players' server lists when
    performing trivial updates. (The launcher should remove the 'sample'
    qualifier when it is performing a full install, though that is not
    implemented right now and the move operation is sadly broken.)
    oldmud0 committed Aug 20, 2020
    Configuration menu
    Copy the full SHA
    accca95 View commit details
    Browse the repository at this point in the history

Commits on Aug 21, 2020

  1. Configuration menu
    Copy the full SHA
    385f476 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    894abc0 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    af1e760 View commit details
    Browse the repository at this point in the history