-
Notifications
You must be signed in to change notification settings - Fork 303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade guide required #184
Comments
Apologies for the same, I am working on Docs. But by upgradable, we mean,
you can upgrade from any version of PawJS (core library) to new version,
without breaking the application.
…On Tue, 5 May, 2020, 7:40 AM Burak Çalık, ***@***.***> wrote:
Description of this repo says "An upgradable boilerplate ...", but there
isn't any upgrade guide available.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#184>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACWDN76FY2GRBLOQXOBJZF3RP5YRZANCNFSM4MZGTLRQ>
.
|
Sorry I may still not be able to understand what actually "upgradable" refer to, thats sounds a little weird to me. For example package.json doesn't contain react library itself and pawjs core actually require react, and react itself may get a breaking change. So pawjs would bump the version to 4 from 3, and that is not upgradable. |
I undesratand, and that is a very good point actually, I am now planning to
move react as Peer Dependency, thus handled by user himself. Thank you for
pointing that out
…On Tue, 5 May, 2020, 9:33 AM Burak Çalık, ***@***.***> wrote:
Sorry I may still not be able to understand what actually "upgradable"
refer to, thats sounds a little weird to me. For example package.json
doesn't contain react library itself and pawjs core actually require react,
and react itself may get a breaking change. So pawjs would bump the version
to 4 from 3, and that is not upgradable.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#184 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACWDN7Z76UUWLFLWXD44QVLRP6FZZANCNFSM4MZGTLRQ>
.
|
That was an example, I'm not really sure if you should move react as peer dependency or not. But thank you for your reply and interest. |
No, Thank you. I will see what term I should use as description so it
represents what it exactly does. It has been a valuable conversation
…On Tue, 5 May, 2020, 9:52 AM Burak Çalık, ***@***.***> wrote:
That was an example, I'm not really sure if you should move react as peer
dependency or not. But thank you for your reply and interest.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#184 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACWDN7YAETGQEBFDC3UMEHTRP6IABANCNFSM4MZGTLRQ>
.
|
Description of this repo says "An upgradable boilerplate ...", but there isn't any upgrade guide available.
The text was updated successfully, but these errors were encountered: