Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade guide required #184

Closed
bcalik opened this issue May 5, 2020 · 5 comments
Closed

Upgrade guide required #184

bcalik opened this issue May 5, 2020 · 5 comments

Comments

@bcalik
Copy link

bcalik commented May 5, 2020

Description of this repo says "An upgradable boilerplate ...", but there isn't any upgrade guide available.

@tirthbodawala
Copy link
Member

tirthbodawala commented May 5, 2020 via email

@bcalik
Copy link
Author

bcalik commented May 5, 2020

Sorry I may still not be able to understand what actually "upgradable" refer to, thats sounds a little weird to me. For example package.json doesn't contain react library itself and pawjs core actually require react, and react itself may get a breaking change. So pawjs would bump the version to 4 from 3, and that is not upgradable.

@tirthbodawala
Copy link
Member

tirthbodawala commented May 5, 2020 via email

@bcalik
Copy link
Author

bcalik commented May 5, 2020

That was an example, I'm not really sure if you should move react as peer dependency or not. But thank you for your reply and interest.

@tirthbodawala
Copy link
Member

tirthbodawala commented May 5, 2020 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants