This repository has been archived by the owner on Oct 4, 2023. It is now read-only.
[C-806] Prevent multiple overflow menus at a time #1698
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
have to do it for the playlist tile too |
|
Preview this change https://demo.audius.co/sd-multiple-menus |
|
done for the playlist tiles too. feels like it can be refactored. |
|
Preview this change https://demo.audius.co/sd-multiple-menus |
sddioulde
force-pushed
the
sd-multiple-menus
branch
from
2199c6a
to
1235190
Compare
sddioulde
force-pushed
the
sd-multiple-menus
branch
from
1235190
to
5db9f47
Compare
|
Preview this change https://demo.audius.co/sd-multiple-menus |
sddioulde
changed the title
raymondjacobson
approved these changes
Aug 10, 2022
added 2 commits
August 11, 2022 09:36
|
Preview this change https://demo.audius.co/sd-multiple-menus |
audius-infra
pushed a commit
that referenced
this pull request
Aug 13, 2022
[0d2f211] [C-826] Move remote-config-instance to saga context (#1713) Dylan Jeffers [bcd68c7] Add sagas for OnRamp to AUDIO (#1666) Marcus Pasell [1ca2af2] Prevent showing file explorer on pressing enter (#1704) Saliou Diallo [0b6f0e4] [PAY-521] Add web dethroned notification (#1712) Michael Piazza [76b1b0e] [C-820] Move apiClient into saga context, Add WalletClient to context (#1711) Dylan Jeffers [2706cef] [C-807] Move audiusBackendInstance into context across all sagas (#1710) Dylan Jeffers [25c9433] [PAY-466] Display AAO emoji errors for failed reward claims (#1693) Reed [c2a79ff] [C-808] Don't show unnecessarily show profile option on overflow menu (#1708) Dylan Jeffers [94e188f] [C-801] Add tag search text to mobile (#1706) Dylan Jeffers [a47c2e2] [C-806] Prevent multiple overflow menus at a time (#1698) Saliou Diallo [dce8a58] [C-797] Fix track-remix-screen text color (#1705) Dylan Jeffers [1325829] Add extends null (#1707) Sebastian Klingler [51e38d6] [C-805] Fix artifact on small card (#1696) Raymond Jacobson [0a521b1] [C-798] Remove owned/created stamp from collectible tile (#1689) Sebastian Klingler [18ae0a0] [C-804] Show playlist count for non-artists in native (#1697) Dylan Jeffers [ffcf0da] Fix associated wallets (#1692) Raymond Jacobson [e287fb1] [PAY-267, C-753] Remove tipping feature flags, Fix mutuals icon (#1695) Dylan Jeffers [118102d] [C-794] Add typecheck to web ci (#1694) Sebastian Klingler [4f60a49] [C-803] Add common state and backend sagas to native (#1691) Dylan Jeffers [96d9cc8] [C-800] Add native saga context and update common sagas (#1690) Dylan Jeffers [12add4a] [C-799] Add saga context, refactor backend state (#1688) Dylan Jeffers [afdbe97] [C-796] Refactor AudiusAPIClient to work in native context (#1687) Dylan Jeffers [a185c09] [C-795] Fix user-list tag imports (#1686) Dylan Jeffers [3a8704c] [C-774] Move audius-backend to common, add native libs-instance (#1685) Dylan Jeffers
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Prevent multiple overflow menus at a time.
The issue was that there was an event.stopPropagation as the click event from the the kebab menu in the track/playlist was bubbling up. This was there so that the underlying track does not play/pause on kebab menu click. However, because the click event stopped bubbling up, the logic for the click outside of already open menus would not trigger, leaving those menus open.
This PR does not stop the click event from bubbling up to the document, and it prevents the play/pause track if the click target is from the kebab menu.
Dragons
Other menu overflow behavior should still work as expected.
How Has This Been Tested?
local vs stage
https://www.loom.com/share/034b9e3fb52e4ac09fdd2b975cd2ad08
How will this change be monitored?
n/a
Feature Flags
none