waudio decimals #2046
Merged
waudio decimals #2046
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jowlee
added
libs
discovery-node
piazzatron
approved these changes
Nov 19, 2021
There was a problem hiding this comment.
We're missing one at the top of challenge.js - WRAPPED_AUDIO_PRECISION.
I think it would be great if we could do a pass here and consolidate this to like one single var per repo - once per libs, once for DN, etc. Feels like we're just asking to mess something up otherwise.
jowlee
force-pushed
the
jowlee-waudio-decimals
branch
from
f6d32b8 to
f07a881
Compare
jowlee
force-pushed
the
jowlee-waudio-decimals
branch
from
45221e2 to
6fd332f
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update the number of decimals for updated wrapped audio from wormhole v2
Switches from 9 decimals to 8 decimals
Tests
How will this change be monitored?
Closes AUD-1059