Skip to content

Conversation

cheran-senthil
Copy link
Contributor

@cheran-senthil cheran-senthil commented Nov 29, 2021

Description

This PR allows logs to be directly sent from the Dockerfile of Discovery and Creator Nodes.

This also adds an env var to control this behavior

Tests

Testing on Sandbox nodes

How will this change be monitored?

@gitguardian
Copy link

gitguardian bot commented Dec 8, 2021

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Details of the secret
Secret Commit Filename Detected At
Generic High Entropy Secret 7035aa2 libs/scripts/communityRewards/transferCommunityRewardsToSolana.js 15:11 December 8th, 2021 View secret
🛠 How to resolve this
  1. Understand the implications of revoking this secret by examining where it is used in your code.

  2. Replace and store your secret safely. Learn here the best practices

  3. Revoke and rotate this secret

  4. If possible, rewrite your git history to remove all evidence of the secret leak. Please beware this is not a trivial operation. You might completely break other contributing developers’ workflow and you risk accidentally deleting work in progress.

💡 To avoid such incidents in the future, consider following these best practices for managing and storing secrets including API keys and other credentials.

You are seeing this because you or someone else has authorized GitGuardian to scan pull requests

@cheran-senthil cheran-senthil merged commit 44cc144 into master Dec 8, 2021
@cheran-senthil cheran-senthil deleted the vss-dockerfile-logging branch December 8, 2021 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants