Don't add empty action

[Rothes]

Adding empty action may cause exception on other things. We should ensure plugin compatibility, e.g Bungee-Chat API cannot parse the json, because there's no empty action.
Fixes Rothes/ProtocolStringReplacer#31

[Aust1n46]

The root cause of your issue seems to stem from the API not being able to handle this valid json payload. The client parses it out just fine.

Your suggested change also does not cover the case where someone types in an invalid click_action. Empty is only one invalid case; the config input is a string field were anything can be typed.

My preferred "fix" to VentureChat would be input validation on the click_action in the json_attributes section of the config. This should take place before reaching down into the formatter. Perhaps during the initialization of the jsonFormats with logging for invalid formats.

[LOOHP]

I agree that simply not sending empty click action is not a good solution. Input validation (i.e. limiting the user to only select from the available set of click action) is a much better way of doing this. Perhaps any invalid click actions set in the config will be treated as if there is no click action and warn the user about this.

Side note: Not only the bungeecord chat API doesn't handle this, the new Adventure API also doesn't handle this. It is much more difficult to get changes into these libraries. An issue I submitted a year ago is still there waiting, also related to how something is accepted in the vanilla client.

Currently, I'm offering this plugin as a "temporary workaround".

[Rothes]

Close as fixed in the other pr.